From owner-svn-src-all@FreeBSD.ORG Wed Apr 23 05:19:54 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A4BD6F64 for ; Wed, 23 Apr 2014 05:19:54 +0000 (UTC) Received: from mail-pb0-f49.google.com (mail-pb0-f49.google.com [209.85.160.49]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 714301E7D for ; Wed, 23 Apr 2014 05:19:54 +0000 (UTC) Received: by mail-pb0-f49.google.com with SMTP id rr13so395599pbb.22 for ; Tue, 22 Apr 2014 22:19:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=4RsPbmFfEkmPBqdxqC5gpIFVNc5y+CRJAa41TLXYMq8=; b=OCBaMlNYHocjwvryiZTuvMl9K2Il//euHT16K4JS6Usw3ukoXgkevmNT4lzpyDPT7C Wh4OP16okvp6sohyFyrLJ8UBxKhsk0PaQ3hAtcqRXO1Y9jCcQhrIfD8jZFYhk3ZkWpvn DWhk1Mv3PawXNa0AVxie+v/gw+xHz8je2j8O49wrzDH2tSOmRBZvBHPt/jzS63H9rMv2 4DmubF0/P3skSO1CK5CgALB7VG7iSrIBWBBPJVWzvCvpplntRxiO6b7fFww9TdUFroYH G3e9jaDI5wTtdAtC1hvo6rV1bSGpoUvlwQ7l/a2kw62bRm4zUzw/CUDqnGlP2WVi4hOl 6XPA== X-Gm-Message-State: ALoCoQmTsEGDqs1quwMKVk93QckBz1bUjTcN1l5ADCdOqLJNYnYbEYqOlEc1Kr83GEdBPZbXb348 X-Received: by 10.68.104.225 with SMTP id gh1mr5493730pbb.87.1398230393939; Tue, 22 Apr 2014 22:19:53 -0700 (PDT) Received: from [10.0.103.142] ([50.242.69.61]) by mx.google.com with ESMTPSA id yo9sm211832674pab.16.2014.04.22.22.19.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Apr 2014 22:19:52 -0700 (PDT) Sender: Warner Losh Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: svn commit: r264794 - head/release/arm From: Warner Losh In-Reply-To: <20140423051709.GY49791@glenbarber.us> Date: Tue, 22 Apr 2014 22:19:50 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <19D9CEFF-ED49-4310-991A-59D35EF8A242@bsdimp.com> References: <201404230201.s3N21NiE054881@svn.freebsd.org> <11A48119-4502-4EE6-A4AF-E726578380DF@gmail.com> <20140423050923.GW49791@glenbarber.us> <20140423051235.GX49791@glenbarber.us> <71240AD4-7635-4694-950D-CDD99960A013@bsdimp.com> <20140423051709.GY49791@glenbarber.us> To: Glen Barber X-Mailer: Apple Mail (2.1874) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Apr 2014 05:19:54 -0000 On Apr 22, 2014, at 10:17 PM, Glen Barber wrote: > On Tue, Apr 22, 2014 at 10:15:14PM -0700, Warner Losh wrote: >>=20 >> On Apr 22, 2014, at 10:12 PM, Glen Barber wrote: >>=20 >>> On Wed, Apr 23, 2014 at 01:09:23AM -0400, Glen Barber wrote: >>>> On Tue, Apr 22, 2014 at 10:02:03PM -0700, Warner Losh wrote: >>>>> Ditto. This should be backed out and you should make whoever broke = this fix it in head. >>>>>=20 >>>>=20 >>>> Well, this commit only moves where the definition is, from the = script >>>> itself to the configuration file. >>>>=20 >>>> But, to be fair, I think you broke it in r264660. >>>>=20 >>>=20 >>> To clarify further, if it was you that did break it in head/, I am = not >>> complaining about it - I fixed the use case I need. >>>=20 >>> What I *want* to happen is for the WITH_CLANG_IS_CC and >>> WITHOUT_CLANG_IS_CC to stop conflicting with WITH_GCC, and = additional >>> convoluted and unnecessary knobs to go away. >>>=20 >>> But you already know that. :) >>=20 >> Yea, see my recent posts to arm@ on that very topic. CLANG_IS_CC >> is evil and must die. There=92s too many stupid special cases for >> clang in the build system, and it is really horking me off=85 But >> there will be fewer in about a week or so when I push my next round >> of fixes in... >>=20 >=20 > Feel free to run your changes by me for testing. I'm happy to > complain^W test. :) Will do=85 My work in progress mercurial patch queue is updating every = day or three at http://people.freebsd.org/~imp/patch-queue if you wanted a sneak peak = and had a mercurial setup already=85 But there=92s also some crazy stuff in = that=85 When I have a patch set I=92m ready to dump into make universe, I=92ll give you a = heads up. And sorry for breaking it in the first place... Warner=