From owner-freebsd-net@FreeBSD.ORG Fri Dec 4 20:23:24 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2ED901065672 for ; Fri, 4 Dec 2009 20:23:24 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.26]) by mx1.freebsd.org (Postfix) with ESMTP id D382E8FC19 for ; Fri, 4 Dec 2009 20:23:23 +0000 (UTC) Received: by qw-out-2122.google.com with SMTP id 9so593065qwb.7 for ; Fri, 04 Dec 2009 12:23:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=Vy8xWfaMnjUh9a7t4V7vAC9IMI56qPUsByxPDwFsQ+c=; b=S0MZpSEggsGmJ5Qff2CepBTVxRw0sarVCLMByuLLA604sww+zDtO12oG+lSd8pDSbi P/oXDBADEszbtyrdntiqLL8BG6w3wCqc0pYgAdK+DeXoFXr7TipFaJooAMUWGOeiuyNt q+HfbMd+HgHNO8m/bqGerUy8YZ4Gxt6fLrhMk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=A9HNKvKCO7f1eYGyypM3nfhj9ch0kN6gWwRFVnS0/+w4unohkAd7q8kcDryMGTe+ev OI+ctI3z+FW8nb6FMGnDCoCn2C98mrtqDEHGHqSzb7Ldxj4V9orcBtw8BixT1T7Hdlu6 TfDIKQzbyyML8AzHqoB1/r/2bcUvandml7GlM= Received: by 10.224.24.84 with SMTP id u20mr1969057qab.160.1259958203076; Fri, 04 Dec 2009 12:23:23 -0800 (PST) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id 26sm8176849qwa.0.2009.12.04.12.23.21 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 04 Dec 2009 12:23:22 -0800 (PST) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Fri, 4 Dec 2009 12:22:13 -0800 From: Pyun YongHyeon Date: Fri, 4 Dec 2009 12:22:13 -0800 To: Igor Sysoev Message-ID: <20091204202213.GI16491@michelle.cdnetworks.com> References: <20091204075440.GH14822@rambler-co.ru> <20091204173243.GC16491@michelle.cdnetworks.com> <20091204191114.GB76992@rambler-co.ru> <20091204195140.GH16491@michelle.cdnetworks.com> <20091204201303.GD76992@rambler-co.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091204201303.GD76992@rambler-co.ru> User-Agent: Mutt/1.4.2.3i Cc: freebsd-net@freebsd.org Subject: Re: hw.bge.forced_collapse X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2009 20:23:24 -0000 On Fri, Dec 04, 2009 at 11:13:03PM +0300, Igor Sysoev wrote: > On Fri, Dec 04, 2009 at 11:51:40AM -0800, Pyun YongHyeon wrote: > > > On Fri, Dec 04, 2009 at 10:11:14PM +0300, Igor Sysoev wrote: > > > On Fri, Dec 04, 2009 at 09:32:43AM -0800, Pyun YongHyeon wrote: > > > > > > > On Fri, Dec 04, 2009 at 10:54:40AM +0300, Igor Sysoev wrote: > > > > > I saw commit introducing hw.bge.forced_collapse loader tunable. > > > > > Just intresting, why it can not be a sysctl ? > > > > > > > > I didn't think the sysctl variable would be frequently changed > > > > in runtime except debugging driver so I took simple path. > > > > > > I do not think it's worth to reboot server just to look how various > > > values affect on bandwidth and CPU usage, expecially in production. > > > > > > As I understand the change is trivial: > > > > > > - CTLFLAG_RD > > > + CTLFLAG_RW > > > > > > since bge_forced_collapse is used atomically. > > > > > > > I have no problem changing it to RW but that case I may have to > > create actual sysctl node(e.g. dev.bge.0.forced_collapse) instead > > of hw.bge.forced_collapse which may affect all bge(4) controllers > > on system. Attached patch may be what you want. You can change the > > value at any time. > > Thank you for the patch. Can it be installed on 8-STABLE ? > bge(4) in HEAD has many fixes which were not MFCed to stable/8 so I'm not sure that patch could be applied cleanly. But I guess you can manually patch it. I'll wait a couple of days for wider testing/review and commit the patch.