From owner-p4-projects Mon Sep 23 9: 5:51 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5523737B406; Mon, 23 Sep 2002 09:05:46 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F0A5A37B401 for ; Mon, 23 Sep 2002 09:05:45 -0700 (PDT) Received: from mail.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82EF743E6E for ; Mon, 23 Sep 2002 09:05:45 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 3108 invoked from network); 23 Sep 2002 16:04:56 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 23 Sep 2002 16:04:56 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g8NG4fBv081738; Mon, 23 Sep 2002 12:04:41 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200209211027.g8LARV58027571@freefall.freebsd.org> Date: Mon, 23 Sep 2002 12:04:44 -0400 (EDT) From: John Baldwin To: Peter Wemm Subject: RE: PERFORCE change 17851 for review Cc: Perforce Change Reviews Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 21-Sep-2002 Peter Wemm wrote: > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=17851 > > Change 17851 by peter@peter_overcee on 2002/09/21 03:27:15 > > nuke tf_isp, it wasn't worth a lot. Errm, does 'pusha' not push ESP on x86-64? It does on i386, and the trapframe contents are partially determined by that. You can't just remove it from the trapframe unless pusha has changed or you will hose all the other variables in the frame. > Affected files ... > > .. //depot/projects/hammer/sys/x86_64/include/reg.h#2 edit > .. //depot/projects/hammer/sys/x86_64/include/signal.h#3 edit > .. //depot/projects/hammer/sys/x86_64/include/ucontext.h#2 edit > .. //depot/projects/hammer/sys/x86_64/x86_64/machdep.c#17 edit > > Differences ... > > ==== //depot/projects/hammer/sys/x86_64/include/reg.h#2 (text+ko) ==== > > @@ -88,7 +88,6 @@ > unsigned int r_edi; > unsigned int r_esi; > unsigned int r_ebp; > - unsigned int r_isp; > unsigned int r_ebx; > unsigned int r_edx; > unsigned int r_ecx; > > ==== //depot/projects/hammer/sys/x86_64/include/signal.h#3 (text+ko) ==== > > @@ -77,7 +77,6 @@ > int sc_edi; > int sc_esi; > int sc_ebp; > - int sc_isp; > int sc_ebx; > int sc_edx; > int sc_ecx; > > ==== //depot/projects/hammer/sys/x86_64/include/ucontext.h#2 (text+ko) ==== > > @@ -45,7 +45,6 @@ > int mc_edi; > int mc_esi; > int mc_ebp; > - int mc_isp; > int mc_ebx; > int mc_edx; > int mc_ecx; > > ==== //depot/projects/hammer/sys/x86_64/x86_64/machdep.c#17 (text+ko) ==== > > @@ -1502,7 +1502,6 @@ > mcp->mc_edi = tp->tf_edi; > mcp->mc_esi = tp->tf_esi; > mcp->mc_ebp = tp->tf_ebp; > - mcp->mc_isp = tp->tf_isp; > mcp->mc_ebx = tp->tf_ebx; > mcp->mc_edx = tp->tf_edx; > mcp->mc_ecx = tp->tf_ecx; -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message