From owner-p4-projects Mon Sep 23 9:15:32 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id F09FE37B404; Mon, 23 Sep 2002 09:15:28 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 403B137B401; Mon, 23 Sep 2002 09:15:28 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3DB943E75; Mon, 23 Sep 2002 09:15:27 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id DEF4B2A7D6; Mon, 23 Sep 2002 09:15:22 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: John Baldwin Cc: Perforce Change Reviews Subject: Re: PERFORCE change 17851 for review In-Reply-To: Date: Mon, 23 Sep 2002 09:15:22 -0700 From: Peter Wemm Message-Id: <20020923161522.DEF4B2A7D6@canning.wemm.org> Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG John Baldwin wrote: > > On 21-Sep-2002 Peter Wemm wrote: > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=17851 > > > > Change 17851 by peter@peter_overcee on 2002/09/21 03:27:15 > > > > nuke tf_isp, it wasn't worth a lot. > > Errm, does 'pusha' not push ESP on x86-64? It does on i386, > and the trapframe contents are partially determined by > that. You can't just remove it from the trapframe unless > pusha has changed or you will hose all the other variables > in the frame. pushal is only a 32 bit instruction. There is no 64 bit version, so that means we get to define our own frame formats. It may as well be in register number order (which I dont think I have right yet). > > Affected files ... > > > > .. //depot/projects/hammer/sys/x86_64/include/reg.h#2 edit > > .. //depot/projects/hammer/sys/x86_64/include/signal.h#3 edit > > .. //depot/projects/hammer/sys/x86_64/include/ucontext.h#2 edit > > .. //depot/projects/hammer/sys/x86_64/x86_64/machdep.c#17 edit > > > > Differences ... > > > > ==== //depot/projects/hammer/sys/x86_64/include/reg.h#2 (text+ko) ==== > > > > @@ -88,7 +88,6 @@ > > unsigned int r_edi; > > unsigned int r_esi; > > unsigned int r_ebp; > > - unsigned int r_isp; > > unsigned int r_ebx; > > unsigned int r_edx; > > unsigned int r_ecx; > > > > ==== //depot/projects/hammer/sys/x86_64/include/signal.h#3 (text+ko) ==== > > > > @@ -77,7 +77,6 @@ > > int sc_edi; > > int sc_esi; > > int sc_ebp; > > - int sc_isp; > > int sc_ebx; > > int sc_edx; > > int sc_ecx; > > > > ==== //depot/projects/hammer/sys/x86_64/include/ucontext.h#2 (text+ko) ==== > > > > @@ -45,7 +45,6 @@ > > int mc_edi; > > int mc_esi; > > int mc_ebp; > > - int mc_isp; > > int mc_ebx; > > int mc_edx; > > int mc_ecx; > > > > ==== //depot/projects/hammer/sys/x86_64/x86_64/machdep.c#17 (text+ko) ==== > > > > @@ -1502,7 +1502,6 @@ > > mcp->mc_edi = tp->tf_edi; > > mcp->mc_esi = tp->tf_esi; > > mcp->mc_ebp = tp->tf_ebp; > > - mcp->mc_isp = tp->tf_isp; > > mcp->mc_ebx = tp->tf_ebx; > > mcp->mc_edx = tp->tf_edx; > > mcp->mc_ecx = tp->tf_ecx; > > -- > > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message