From owner-freebsd-bugs  Fri Jul 18 12:10:07 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id MAA10616
          for bugs-outgoing; Fri, 18 Jul 1997 12:10:07 -0700 (PDT)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id MAA10606;
          Fri, 18 Jul 1997 12:10:03 -0700 (PDT)
Resent-Date: Fri, 18 Jul 1997 12:10:03 -0700 (PDT)
Resent-Message-Id: <199707181910.MAA10606@hub.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, itojun@itojun.org
Received: from coconut.itojun.org (itojun@coconut.itojun.org [133.138.201.163])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id MAA10414
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 18 Jul 1997 12:06:06 -0700 (PDT)
Received: (from itojun@localhost) by coconut.itojun.org (8.8.5/3.5Wpl7) id EAA05566; Sat, 19 Jul 1997 04:06:02 +0900 (JST)
Message-Id: <199707181906.EAA05566@coconut.itojun.org>
Date: Sat, 19 Jul 1997 04:06:02 +0900 (JST)
From: Jun-ichiro ITOH <itojun@itojun.org>
Reply-To: itojun@itojun.org
To: FreeBSD-gnats-submit@FreeBSD.ORG
Cc: itojun@csl.sony.co.jp
X-Send-Pr-Version: 3.2
Subject: kern/4117: if_spppsubr.c: problem talking with cisco via cisco hdlc
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         4117
>Category:       kern
>Synopsis:       if_spppsubr.c: problem talking with cisco via cisco hdlc
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jul 18 12:10:03 PDT 1997
>Last-Modified:
>Originator:     Jun-ichiro ITOH
>Organization:
Sony CSL Inc., Tokyo, Japan
>Release:        FreeBSD 2.2.1-RELEASE i386
>Environment:

FreeBSD coconut.itojun.org 2.2.1-RELEASE FreeBSD 2.2.1-RELEASE #3: Sun Apr 20 14:28:44 JST 1997     root@coconut.itojun.org:/usr/src/sys/compile/COCONUT  i386

	the bug still remains in the FreeBSD-current.

>Description:

	(this is a resend. sorry if duplicated)
	FreeBSD+riscom box can't talk with cisco router via cisco hdlc.

>How-To-Repeat:

	try to connect FreeBSD+riscom with cisco.

>Fix:

	If nobody objects it, i can commit it myself.
	
--- if_spppsubr.c-dist	Fri Jul 18 13:29:11 1997
+++ if_spppsubr.c	Fri Jul 18 13:32:37 1997
@@ -920,7 +920,7 @@
 	struct ifaddr *ifa;
 	struct ifnet *ifp = &sp->pp_if;
 
-	if (m->m_pkthdr.len != CISCO_PACKET_LEN) {
+	if (m->m_pkthdr.len < CISCO_PACKET_LEN) {
 		if (ifp->if_flags & IFF_DEBUG)
 			printf ("%s%d: invalid cisco packet length: %d bytes\n",
 				ifp->if_name, ifp->if_unit, m->m_pkthdr.len);

>Audit-Trail:
>Unformatted: