From owner-svn-ports-head@freebsd.org Thu Jul 9 17:20:56 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2916997A94; Thu, 9 Jul 2015 17:20:56 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7B8781F52; Thu, 9 Jul 2015 17:20:55 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.1.20] (141.Red-83-32-2.dynamicIP.rima-tde.net [83.32.2.141]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 35C0C43BB7; Thu, 9 Jul 2015 12:20:51 -0500 (CDT) Subject: Re: svn commit: r391626 - head/games/warzone2100 To: Dmitry Marakasov References: <201507090944.t699iqBR039850@repo.freebsd.org> <559E431B.6030708@marino.st> <20150709171246.GB46547@hades.panopticon> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Reply-To: marino@freebsd.org From: John Marino Message-ID: <559EAD6F.3050409@marino.st> Date: Thu, 9 Jul 2015 19:20:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150709171246.GB46547@hades.panopticon> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 17:20:56 -0000 On 7/9/2015 7:12 PM, Dmitry Marakasov wrote: > * John Marino (freebsd.contact@marino.st) wrote: > >>> Author: amdmi3 >>> Date: Thu Jul 9 09:44:51 2015 >>> New Revision: 391626 >>> URL: https://svnweb.freebsd.org/changeset/ports/391626 >>> >>> Log: >>> - Remove unncecessary full path to binary from *_DEPENDS >>> >>> Modified: >>> head/games/warzone2100/Makefile >>> >>> Modified: head/games/warzone2100/Makefile >>> ============================================================================== >>> --- head/games/warzone2100/Makefile Thu Jul 9 09:44:33 2015 (r391625) >>> +++ head/games/warzone2100/Makefile Thu Jul 9 09:44:51 2015 (r391626) >>> @@ -13,7 +13,7 @@ LICENSE_FILE= ${WRKSRC}/COPYING >>> >>> BUILD_DEPENDS= zip:${PORTSDIR}/archivers/zip \ >>> unzip:${PORTSDIR}/archivers/unzip \ >>> - ${LOCALBASE}/bin/flex:${PORTSDIR}/textproc/flex >>> + flex:${PORTSDIR}/textproc/flex >>> LIB_DEPENDS= libphysfs.so:${PORTSDIR}/devel/physfs \ >>> libpng.so:${PORTSDIR}/graphics/png \ >>> libvorbis.so:${PORTSDIR}/audio/libvorbis \ >>> >> >> This could be a mistake. >> This changes depends from /usr/local/bin/flex to /usr/bin/flex. >> Are you sure that's what you want to do? > > As I understand, that's why binary names are preferred: as there's > /usr/bin/flex, unneeded dependency won't be installed. However, that > seem to be an artifact from 6.x days, and this dependency is not needed > at all, all supported FreeBSD releases have flex in base system. > My understanding is that you created a dependency specification that is only accidently satisfied. You asked textproc/flex to be installed, but then check /usr/bin/flex from that package (which is not inside). Flex is notorious. If flex is specified in BUILD_DEPENDS, then 100% of the time, you really, really want /usr/local/bin/flex. If /usr/bin/flex works, then you would not put it in BUILD_DEPENDS. /usr/bin/flex is available on all releases so if it works as you say, then textproc/flex will never get pulled in. My guess is that if textproc/flex is listed here, then it's needed over the base flex. Thus, I think the change is an error. John