From owner-freebsd-bugs  Wed Jun 21 15:29:50 1995
Return-Path: bugs-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id PAA10654
          for bugs-outgoing; Wed, 21 Jun 1995 15:29:50 -0700
Received: from kryten.atinc.com (kryten.atinc.com [198.138.38.7])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id PAA10648
          for <bugs@FreeBSD.org>; Wed, 21 Jun 1995 15:29:48 -0700
Received: (jmb@localhost) by kryten.atinc.com (8.6.9/8From owner-freebsd-bugs  Wed Jun 21 15:50:01 1995
Return-Path: bugs-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id PAA11661
          for bugs-outgoing; Wed, 21 Jun 1995 15:50:01 -0700
Received: (from gnats@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id PAA11654
          ; Wed, 21 Jun 1995 15:50:01 -0700
Date: Wed, 21 Jun 1995 15:50:01 -0700
Message-Id: <199506212250.PAA11654@freefall.cdrom.com>
From: tom@haven.uniserve.com
Reply-To: tom@haven.uniserve.com
To: freebsd-bugs
Subject: bin/539: 
In-Reply-To: Your message of Wed, 21 Jun 1995 15:49:29 +0100
	<95Jun21.154940+0100_pdt.30740+2018@haven.uniserve.com>
Sender: bugs-owner@FreeBSD.org
Precedence: bulk


>Number:         539
>Category:       bin
>Synopsis:       
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs (FreeBSD bugs mailing list)
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 21 15:50:00 1995
>Originator:     Tom Samplonius
>Organization:
	UNIServe
>Release:        FreeBSD 2.0.5-RELEASE
>Environment:


>Description:

  finger scans every home direcotry for .nofinger rather than checking
home directories of the users that actually match.

>How-To-Repeat:

  Use finger with large number of users

>Fix:
	
	Only check home directories if they match.  The following patch
moves the hide() call just after the match() call so that only home directories
of matched users get checked.

*** finger.c.old	Wed Jun 21 14:19:50 1995
--- finger.c	Wed Jun 21 14:29:14 1995
***************
*** 261,270 ****
  				    "finger: %s: no such user\n", *p);
  	else {
  		while (pw = getpwent()) {
- 			if (hide (pw))
- 				continue;
  			for (p = argv, ip = used; *p; ++p, ++ip)
! 				if (match(pw, *p)) {
  					enter_person(pw);
  					*ip = 1;
  				}
--- 261,268 ----
  				    "finger: %s: no such user\n", *p);
  	else {
  		while (pw = getpwent()) {
  			for (p = argv, ip = used; *p; ++p, ++ip)
! 				if (match(pw, *p) && !hide(pw)) {
  					enter_person(pw);
  					*ip = 1;
  				}
>Audit-Trail:
>Unformatted:


	finger checks every home directory for .nofinger