From owner-freebsd-stable@FreeBSD.ORG Wed Jun 23 19:16:45 2010 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0ACEE106566C; Wed, 23 Jun 2010 19:16:45 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [IPv6:2001:470:a803::1]) by mx1.freebsd.org (Postfix) with ESMTP id A08AF8FC1C; Wed, 23 Jun 2010 19:16:44 +0000 (UTC) Received: from mail.geekcn.org (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id B33B6A58E3C; Thu, 24 Jun 2010 03:16:43 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by mail.geekcn.org (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with LMTP id W-oHaYKiDLAM; Thu, 24 Jun 2010 03:16:37 +0800 (CST) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id DB429A58E3E; Thu, 24 Jun 2010 03:16:35 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type; b=XrAEtUjtp4SUh/Ixn5bnc6lELo17/Yc4uzR63GJQ5z4W5KxLw5FB+BsY069A/pbdB 8eqk4u8yus7FSQeO2Lgiw== Message-ID: <4C225D90.9020100@delphij.net> Date: Wed, 23 Jun 2010 12:16:32 -0700 From: Xin LI Organization: The Geek China Organization User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.10) Gecko/20100621 Thunderbird/3.0.5 ThunderBrowse/3.2.8.1 MIME-Version: 1.0 To: Jung-uk Kim References: <20100623025855.82916.qmail@exxodus.fedaykin.here> <4C225572.8020602@delphij.net> <201006231501.38985.jkim@FreeBSD.org> <201006231510.50863.jkim@FreeBSD.org> In-Reply-To: <201006231510.50863.jkim@FreeBSD.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: multipart/mixed; boundary="------------030000090201040702030204" Cc: d@delphij.net, freebsd-stable@FreeBSD.org, Mario Sergio Fujikawa Ferreira Subject: Re: FreeBSD 8.1-PRERELEASE: WARNING ioctl sign-extension ioctl ffffffff8004667e X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2010 19:16:45 -0000 This is a multi-part message in MIME format. --------------030000090201040702030204 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 2010/06/23 12:10, Jung-uk Kim wrote: > It is still a kludge and it won't be fixed. :-( Another thought - what about just hiding the printf under #ifdef DIAGNOSTIC... I don't really see any reason why we must print it out if we truncate it every time... Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (FreeBSD) iQEcBAEBCAAGBQJMIl2QAAoJEATO+BI/yjfBpz0IAM88YOx5CVoYRCEW8EwCaW+N 5Ugks9hCvbsJgU2yLxeg5hGal0wOHKONLxaq9pXvQFybgRT9SLmna2FJLTJ6XYTu pjtjeby40mpwRTwU5rZgJ//aYgHW48kK9N/CoE63zKycYQbjLFGnZmXbel9itZzL Xnpj9kc0zlpqtk6yZd4XA+m90VrIgnMKmxeP0A5OzuWJKUBmvciqSMYEBQ0pkP03 sSiN5QIzW/gRMgYSJEsTGz5+q10ZDf0NOecuhOujLphWLzWxkq6UOqRi3JXvFaqo ajRDpGEG65r2IDd8qo4y50U0FGeHmysTFUPU3aAOzjb10LbNbmT6zX+3G1rSMFY= =A2pe -----END PGP SIGNATURE----- --------------030000090201040702030204 Content-Type: text/plain; name="sys_generic.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="sys_generic.c.diff" Index: sys/kern/sys_generic.c =================================================================== --- sys/kern/sys_generic.c (revision 209472) +++ sys/kern/sys_generic.c (working copy) @@ -628,9 +628,11 @@ caddr_t data; if (uap->com > 0xffffffff) { +#ifdef DIAGNOSTIC printf( "WARNING pid %d (%s): ioctl sign-extension ioctl %lx\n", td->td_proc->p_pid, td->td_name, uap->com); +#endif uap->com &= 0xffffffff; } com = uap->com; --------------030000090201040702030204--