From owner-freebsd-ports@FreeBSD.ORG Sun Jun 30 17:26:38 2013 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D700E481 for ; Sun, 30 Jun 2013 17:26:38 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) by mx1.freebsd.org (Postfix) with ESMTP id 9FAAC1648 for ; Sun, 30 Jun 2013 17:26:38 +0000 (UTC) Received: from meatwad.mouf.net (cpe-098-122-148-024.nc.res.rr.com [98.122.148.24]) (authenticated bits=0) by mouf.net (8.14.5/8.14.5) with ESMTP id r5UHQNpK029125 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Sun, 30 Jun 2013 17:26:30 GMT (envelope-from swills@FreeBSD.org) Message-ID: <51D06A3F.1040108@FreeBSD.org> Date: Sun, 30 Jun 2013 17:26:23 +0000 From: Steve Wills User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130607 Thunderbird/17.0.6 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: CFT: [patch] making -jX builds the default References: <20130630164011.GA57563@regency.nsu.ru> In-Reply-To: <20130630164011.GA57563@regency.nsu.ru> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Sun, 30 Jun 2013 17:26:31 +0000 (UTC) X-Spam-Status: No, score=1.3 required=4.5 tests=RCVD_IN_RP_RNBL autolearn=no version=3.3.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on mouf.net X-Virus-Scanned: clamav-milter 0.97.8 at mouf.net X-Virus-Status: Clean Cc: ports@FreeBSD.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jun 2013 17:26:38 -0000 On 06/30/13 16:40, Alexey Dokuchaev wrote: > Hi there, > > In attempt to catch (hopefully) last few remaining jobs-unsafe ports, and > thus to make upcoming expruns fallouts easier to handle, I'm sending small > patch I've been using locally for a while to get larger exposure. Patch > was sent to portmgr@ guys for review about a month earlier, it seems DTRT > at the first glances. :-) > > FORCE_MAKE_JOBS is removed because it is the default. While here, I've > moved empty(MAKE_JOBS_NUMBER) check higher, IMHO where it should belong, > also saves a few lines. Testing and feedback are welcome! Let's finally > flip the damn switch! ;-) +1 I've been running with FORCE_MAKE_JOBS for a long time and rarely encounter issues. Steve