From owner-svn-ports-head@freebsd.org Thu Jul 9 18:52:17 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4754997687; Thu, 9 Jul 2015 18:52:17 +0000 (UTC) (envelope-from unicomp@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AD1291933; Thu, 9 Jul 2015 18:52:17 +0000 (UTC) (envelope-from unicomp@marino.st) Received: from [192.168.1.20] (141.Red-83-32-2.dynamicIP.rima-tde.net [83.32.2.141]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id B296A43C0B; Thu, 9 Jul 2015 13:52:13 -0500 (CDT) Subject: Re: svn commit: r391655 - head/databases/rocksdb To: Tijl Coosemans , Sunpoet Po-Chuan Hsieh References: <201507091548.t69FmxqL020735@repo.freebsd.org> <20150709204758.0d63e354@kalimero.tijl.coosemans.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: John Marino Message-ID: <559EC2D7.5070004@marino.st> Date: Thu, 9 Jul 2015 20:52:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150709204758.0d63e354@kalimero.tijl.coosemans.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 18:52:17 -0000 On 7/9/2015 8:47 PM, Tijl Coosemans wrote: > On Thu, 9 Jul 2015 15:48:59 +0000 (UTC) Sunpoet Po-Chuan Hsieh wrote: >> Author: sunpoet >> Date: Thu Jul 9 15:48:58 2015 >> New Revision: 391655 >> URL: https://svnweb.freebsd.org/changeset/ports/391655 >> >> Log: >> - Mark BROKEN on DragonFly BSD >> >> PR: 201341 >> Submitted by: marino >> >> Modified: >> head/databases/rocksdb/Makefile >> >> Modified: head/databases/rocksdb/Makefile >> ============================================================================== >> --- head/databases/rocksdb/Makefile Thu Jul 9 15:44:50 2015 (r391654) >> +++ head/databases/rocksdb/Makefile Thu Jul 9 15:48:58 2015 (r391655) >> @@ -25,6 +25,8 @@ USES= compiler:c++11-lib gmake >> GH_ACCOUNT= facebook >> USE_GITHUB= yes >> >> +BROKEN_DragonFly= does not build on DragonFly BSD using GCC with -Werror >> + > > Normally you would just patch out -Werror, but in this case upstream > added a convenient flag for that so you can add: > > MAKE_ARGS= -DDISABLE_WARNING_AS_ERROR > > If it's broken on DragonFly it's probably broken on FreeBSD too with > modern GCC. > It was there; sunpoet reverted that valid commit. http://www.freshports.org/commit.php?category=databases&port=rocksdb&files=yes&message_id=201507041521.t64FLT91060382@repo.freebsd.org Since I'm not playing his games, I requested the BROKEN. (see PR if you care) John