From owner-svn-src-all@FreeBSD.ORG Sat Jul 17 18:05:37 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 214A41065677; Sat, 17 Jul 2010 18:05:37 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id D1B548FC0A; Sat, 17 Jul 2010 18:05:35 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 2DA3E730A1; Sat, 17 Jul 2010 20:16:31 +0200 (CEST) Date: Sat, 17 Jul 2010 20:16:31 +0200 From: Luigi Rizzo To: Rui Paulo Message-ID: <20100717181631.GA89827@onelab2.iet.unipi.it> References: <201007151441.o6FEf6Lc015448@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, Luigi Rizzo , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r210121 - head/sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jul 2010 18:05:37 -0000 On Sat, Jul 17, 2010 at 02:21:48PM +0100, Rui Paulo wrote: > > On 15 Jul 2010, at 15:41, Luigi Rizzo wrote: > > > Author: luigi > > Date: Thu Jul 15 14:41:06 2010 > > New Revision: 210121 > > URL: http://svn.freebsd.org/changeset/base/210121 > > > > Log: > > small portability fix to build on linux/windows > > Do we really want this, especially on sys? the alternative would be to keep a separate tree with cross platform sources, and periodically import the code in FreeBSD. This seems largely overkill considering that 1. most of the development of ipfw/dummynet occurs within FreeBSD and there are several people besides myself contributing features and bugfixes; 2. as you can see, the number and size of OS-specific parts is very very small (this was one of my goals when porting it) so there is no loss of readability. Also, I am deliberately avoiding any change that would cause a loss of performance on FreeBSD: in case, i put the extra burden on other platforms. cheers luigi