From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Dec 14 20:50:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EA15F4EB for ; Sat, 14 Dec 2013 20:50:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AAE2A1DC3 for ; Sat, 14 Dec 2013 20:50:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rBEKo0qb067444 for ; Sat, 14 Dec 2013 20:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rBEKo0oK067443; Sat, 14 Dec 2013 20:50:00 GMT (envelope-from gnats) Resent-Date: Sat, 14 Dec 2013 20:50:00 GMT Resent-Message-Id: <201312142050.rBEKo0oK067443@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Thomas Zander Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8F4ED211 for ; Sat, 14 Dec 2013 20:42:32 +0000 (UTC) Received: from oldred.freebsd.org (oldred.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7B7F11D7E for ; Sat, 14 Dec 2013 20:42:32 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id rBEKgWtr070843 for ; Sat, 14 Dec 2013 20:42:32 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id rBEKgW5k070829; Sat, 14 Dec 2013 20:42:32 GMT (envelope-from nobody) Message-Id: <201312142042.rBEKgW5k070829@oldred.freebsd.org> Date: Sat, 14 Dec 2013 20:42:32 GMT From: Thomas Zander To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/184768: [PATCH] audio/musicpd does not play wma files X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Dec 2013 20:50:01 -0000 >Number: 184768 >Category: ports >Synopsis: [PATCH] audio/musicpd does not play wma files >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Dec 14 20:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Thomas Zander >Release: >Organization: >Environment: >Description: Since musicpd uses ffmpeg >= 1.0, it does no longer play wma files. A trivial patch for this change to the ffmpeg API has been committed upstream but did not make it into a release yet, see https://github.com/bjaglin/mpd/commit/a84774fd46e4f3b6147bfd3d19ff4841bde8c98d Since we don't know when the next release of mpd with this patch will be, we should include this into our ports tree for now. >How-To-Repeat: Play any wma or asf file that works in mplayer. It won't work in the ports version of musicpd. >Fix: Patch is attached. Just place it in ${PORTSDIR}/audio/musicpd/files. Rebuild musicpd. All good :-) Patch attached with submission follows: --- src/decoder/ffmpeg_decoder_plugin.c.orig 2013-01-07 01:39:40.000000000 +0100 +++ src/decoder/ffmpeg_decoder_plugin.c 2013-12-14 21:22:19.284609914 +0100 @@ -395,6 +395,11 @@ #endif return SAMPLE_FORMAT_S32; +#if LIBAVUTIL_VERSION_INT >= AV_VERSION_INT(51,17,0) + case AV_SAMPLE_FMT_FLTP: + return SAMPLE_FORMAT_FLOAT; +#endif + default: break; } >Release-Note: >Audit-Trail: >Unformatted: