Date: Mon, 7 Mar 2005 11:59:27 +0900 From: Pyun YongHyeon <yongari@kt-is.co.kr> To: Alexander Leidinger <Alexander@Leidinger.net> Cc: Mathew Kanner <mat@cnd.mcgill.ca> Subject: Re: uaudio patch, configurable buffer size Message-ID: <20050307025927.GB951@kt-is.co.kr> In-Reply-To: <20050306162811.694d9c82@Magellan.Leidinger.net> References: <20050305224005.GC4237@cnd.mcgill.ca> <20050306162811.694d9c82@Magellan.Leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 06, 2005 at 04:28:11PM +0100, Alexander Leidinger wrote: > On Sat, 5 Mar 2005 17:40:05 -0500 > Mathew Kanner <mat@cnd.mcgill.ca> wrote: > > > Hi All, > > I couldn't use my usb device because the default buffer size > > (16*1024 bytes) was too much to be allocated (dma changes that > > happened a while ago). The following is a patch to make it a tunable: > > > > http://www.cnd.mcgill.ca/~mat/uaudio-HEAD-buffersize-tunable.diff.gz > > There's an open PR about it. It changes the buffer size. AFAIR it also > talks about changing the value of a parameter to a busdma call instead. > I've patched the busdma call and now the device is detected here (but I > don't hear any output...). > > I think you should add another set of validation code: The buffer size > is divided by 2 in the code, so I think it should at least print a > warning if "buffsize % 2 != 0". > AFAIK no. The buffer size should be power of 2. See pcm_getbuffersize() in sound.c. -- Regards, Pyun YongHyeon http://www.kr.freebsd.org/~yongari | yongari@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050307025927.GB951>