From owner-p4-projects  Tue Oct  1  8:27: 4 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 21F7437B406; Tue,  1 Oct 2002 08:27:02 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AA4A237B404
	for <perforce@freebsd.org>; Tue,  1 Oct 2002 08:27:01 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6AA0943E6E
	for <perforce@freebsd.org>; Tue,  1 Oct 2002 08:27:01 -0700 (PDT)
	(envelope-from cvance@tislabs.com)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g91FR1Co057026
	for <perforce@freebsd.org>; Tue, 1 Oct 2002 08:27:01 -0700 (PDT)
	(envelope-from cvance@tislabs.com)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g91FQvsx057010
	for perforce@freebsd.org; Tue, 1 Oct 2002 08:26:57 -0700 (PDT)
Date: Tue, 1 Oct 2002 08:26:57 -0700 (PDT)
Message-Id: <200210011526.g91FQvsx057010@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to cvance@tislabs.com using -f
From: Chris Vance <cvance@FreeBSD.org>
Subject: PERFORCE change 18468 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18468

Change 18468 by cvance@cvance_laptop on 2002/10/01 08:26:45

	Make sure vnode is locked before calling VOP_GETATTR,

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#6 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/security/sebsd/avc/avc.c#6 (text+ko) ====

@@ -494,10 +494,17 @@
 			if (a->u.fs.vp) {
 				struct vnode *vp = a->u.fs.vp;
 				struct vattr va;
-				VOP_GETATTR(vp, &va, curthread->td_ucred, 
-					    curthread);
-				printf(" inode=%d, fsid=%d, ftype=%d",
-				       va.va_fileid, va.va_fsid, vp->v_type);
+				if (VOP_ISLOCKED(vp, curthread) &&
+				    VOP_GETATTR(vp, &va,
+						curthread->td_ucred,
+						curthread)) {
+					printf(" inode=%d, fsid=%d, ftype=%d",
+					       va.va_fileid, va.va_fsid, 
+					       vp->v_type);
+				} else {
+					printf(" ERROR lock not held, no "
+					       "inode/fsid info available"); 
+				}
 				       
 			}
 			break;

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message