From owner-freebsd-current@FreeBSD.ORG Mon Aug 22 11:12:25 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B21A16A41F for ; Mon, 22 Aug 2005 11:12:25 +0000 (GMT) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2051B43D46 for ; Mon, 22 Aug 2005 11:12:23 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 15904 invoked from network); 22 Aug 2005 10:51:52 -0000 Received: from dotat.atdotat.at (HELO [62.48.0.47]) ([62.48.0.47]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 22 Aug 2005 10:51:52 -0000 Message-ID: <4309B316.5080106@freebsd.org> Date: Mon, 22 Aug 2005 13:12:22 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b) Gecko/20050217 MIME-Version: 1.0 To: Poul-Henning Kamp References: <62870.1124699921@phk.freebsd.dk> In-Reply-To: <62870.1124699921@phk.freebsd.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Divacky Roman , freebsd-current@freebsd.org, Giorgos Keramidas , Kris Kennaway Subject: Re: [PATCH]: fdalloc optimization X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2005 11:12:25 -0000 Poul-Henning Kamp wrote: > In message <20050822083320.GA32668@stud.fit.vutbr.cz>, Divacky Roman writes: > > >> N Min Max Median Avg Stddev >>x 100 39957 959570 41444 87169.69 201011.84 >>+ 100 37786 962107 38766 66353.09 158258.74 >>No difference proven at 95.0% confidence >> >>anyway - commenting out duplicate code MUST speed it up, maybe insignificantly >>but still ;) > > > It used to be that life was that simple, but with three levels of caches and > deep pipelines it isn't anymore. > > But taken from the other side: you can also read this as your patch does no > damage to performance, so if code clarity is improved (havn't looked at your > patch myself) then that would be another good reason. Danfe posted about some DFBSD work in that area an hour ago. -- Andre