From owner-p4-projects Tue Oct 1 13:32:53 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id C2E7F37B404; Tue, 1 Oct 2002 13:32:51 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 72E2037B401; Tue, 1 Oct 2002 13:32:51 -0700 (PDT) Received: from magic.adaptec.com (magic.adaptec.com [208.236.45.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D2CD43E3B; Tue, 1 Oct 2002 13:32:51 -0700 (PDT) (envelope-from gibbs@scsiguy.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11] (may be forged)) by magic.adaptec.com (8.10.2+Sun/8.10.2) with ESMTP id g91KWkN06044; Tue, 1 Oct 2002 13:32:46 -0700 (PDT) Received: from btc.btc.adaptec.com (btc.btc.adaptec.com [10.100.0.52]) by redfish.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id NAA07039; Tue, 1 Oct 2002 13:32:45 -0700 (PDT) Received: from [10.100.253.70] (aslan [10.100.253.70]) by btc.btc.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id OAA17743; Tue, 1 Oct 2002 14:32:43 -0600 (MDT) Date: Tue, 01 Oct 2002 14:32:44 -0600 From: "Justin T. Gibbs" Reply-To: "Justin T. Gibbs" To: John Baldwin , Perforce Change Reviews Subject: Re: PERFORCE change 18492 for review Message-ID: <3436740000.1033504364@aslan.btc.adaptec.com> In-Reply-To: <200210012014.g91KEMNY078476@freefall.freebsd.org> References: <200210012014.g91KEMNY078476@freefall.freebsd.org> X-Mailer: Mulberry/3.0.0a4 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18492 > > Change 18492 by jhb@jhb_laptop on 2002/10/01 13:13:59 > > Add a workaround for a PPro Errata with the idea basically > taken from NetBSD. The comment in the code is not very useful considering the errata list may move or disappear from Intel's web site. Why not just say: /* * Workaround for PentiumPro Errata 5AP: Spurious interrupts routed to * int15 in APIC virtual wire mode. */ It certainly goes a long way toward explaining why you are hooking a vector. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message