From owner-p4-projects Wed Oct 2 21:14:41 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A780C37B401; Wed, 2 Oct 2002 21:14:39 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 56A2437B401 for ; Wed, 2 Oct 2002 21:14:39 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0EB9B43E42 for ; Wed, 2 Oct 2002 21:14:39 -0700 (PDT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g934EcCo017901 for ; Wed, 2 Oct 2002 21:14:38 -0700 (PDT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g934EcQw017897 for perforce@freebsd.org; Wed, 2 Oct 2002 21:14:38 -0700 (PDT) Date: Wed, 2 Oct 2002 21:14:38 -0700 (PDT) Message-Id: <200210030414.g934EcQw017897@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson Subject: PERFORCE change 18572 for review To: Perforce Change Reviews Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18572 Change 18572 by rwatson@rwatson_tislabs on 2002/10/02 21:13:55 Back out apparent incorrect solution to problems with extended attributes on specfs vnodes in UFS2. Vnode operation vectors default to eopnotsupp unless overridden, so the change in question was essentially a noop. It also didn't fix the problem with EAs, which relates to VOP_WRITE() being implemented by specfs not ffs, and therefore the IO_EXT components of the write not getting directed to the right implementation. This is one potential problem with choosing to implement extended attribute operations using the existing ffs_readwrite implementation, as it composes improperly when you have pseudo-file systems like specfs. Affected files ... .. //depot/projects/trustedbsd/mac/sys/fs/specfs/spec_vnops.c#12 edit Differences ... ==== //depot/projects/trustedbsd/mac/sys/fs/specfs/spec_vnops.c#12 (text+ko) ==== @@ -107,10 +107,6 @@ { &vop_lock_desc, (vop_t *) vop_nolock }, { &vop_unlock_desc, (vop_t *) vop_nounlock }, { &vop_islocked_desc, (vop_t *) vop_noislocked }, - { &vop_getextattr_desc, (vop_t *) vop_eopnotsupp }, - { &vop_setextattr_desc, (vop_t *) vop_eopnotsupp }, - { &vop_openextattr_desc, (vop_t *) vop_eopnotsupp }, - { &vop_closeextattr_desc, (vop_t *) vop_eopnotsupp }, { NULL, NULL } }; static struct vnodeopv_desc spec_vnodeop_opv_desc = To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message