From owner-p4-projects  Thu Oct  3  7:16:12 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 20AD237B404; Thu,  3 Oct 2002 07:16:10 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A0C2F37B401
	for <perforce@freebsd.org>; Thu,  3 Oct 2002 07:16:09 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5B21C43E4A
	for <perforce@freebsd.org>; Thu,  3 Oct 2002 07:16:09 -0700 (PDT)
	(envelope-from green@freebsd.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g93EG9Co059826
	for <perforce@freebsd.org>; Thu, 3 Oct 2002 07:16:09 -0700 (PDT)
	(envelope-from green@freebsd.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g93EG83T059821
	for perforce@freebsd.org; Thu, 3 Oct 2002 07:16:08 -0700 (PDT)
Date: Thu, 3 Oct 2002 07:16:08 -0700 (PDT)
Message-Id: <200210031416.g93EG83T059821@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to green@freebsd.org using -f
From: Brian Feldman <green@FreeBSD.org>
Subject: PERFORCE change 18586 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18586

Change 18586 by green@green_laptop_2 on 2002/10/03 07:15:58

	Don't uselessly follow symlinks in the extattr utilities.

Affected files ...

.. //depot/projects/trustedbsd/mac/usr.sbin/extattr/rmextattr.8#2 edit
.. //depot/projects/trustedbsd/mac/usr.sbin/extattr/rmextattr.c#3 edit

Differences ...

==== //depot/projects/trustedbsd/mac/usr.sbin/extattr/rmextattr.8#2 (text+ko) ====

@@ -77,6 +77,9 @@
 the name of the target file or directory,
 .Ar attrvalue
 a string to store in the attribute.
+Since it is not useful to operate on the target of a symbolic link, the given
+.Ar filename
+is not followed if it is one.
 .Pp
 The following options are available:
 .Bl -tag -width flag

==== //depot/projects/trustedbsd/mac/usr.sbin/extattr/rmextattr.c#3 (text+ko) ====

@@ -178,25 +178,25 @@
 	for (arg_counter = 0; arg_counter < argc; arg_counter++) {
 		switch (what) {
 		case EARM:
-			error = extattr_delete_file(argv[arg_counter],
+			error = extattr_delete_link(argv[arg_counter],
 			    attrnamespace, attrname);
 			if (error >= 0)
 				continue;
 			break;
 		case EASET:
-			error = extattr_set_file(argv[arg_counter],
+			error = extattr_set_link(argv[arg_counter],
 			    attrnamespace, attrname, buf, strlen(buf));
 			if (error >= 0)
 				continue;
 			break;
 		case EALS:
 		case EAGET:
-			error = extattr_get_file(argv[arg_counter],
+			error = extattr_get_link(argv[arg_counter],
 			    attrnamespace, attrname, NULL, 0);
 			if (error < 0)
 				break;
 			mkbuf(&buf, &buflen, error);
-			error = extattr_get_file(argv[arg_counter],
+			error = extattr_get_link(argv[arg_counter],
 			    attrnamespace, attrname, buf, buflen);
 			if (error < 0)
 				break;

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message