From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Oct 5 13:30:17 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1F6AC106566C for ; Fri, 5 Oct 2012 13:30:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D319D8FC17 for ; Fri, 5 Oct 2012 13:30:16 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q95DUGOQ055998 for ; Fri, 5 Oct 2012 13:30:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q95DUGcO055988; Fri, 5 Oct 2012 13:30:16 GMT (envelope-from gnats) Resent-Date: Fri, 5 Oct 2012 13:30:16 GMT Resent-Message-Id: <201210051330.q95DUGcO055988@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Manuel Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BCABF1065674 for ; Fri, 5 Oct 2012 13:23:49 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id A74998FC1D for ; Fri, 5 Oct 2012 13:23:49 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q95DNn3C074319 for ; Fri, 5 Oct 2012 13:23:49 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q95DNnvn074318; Fri, 5 Oct 2012 13:23:49 GMT (envelope-from nobody) Message-Id: <201210051323.q95DNnvn074318@red.freebsd.org> Date: Fri, 5 Oct 2012 13:23:49 GMT From: Manuel To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/172355: [PATCH] ports-mgmt/portconf: allow dash and plus symbols in variable names X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2012 13:30:17 -0000 >Number: 172355 >Category: ports >Synopsis: [PATCH] ports-mgmt/portconf: allow dash and plus symbols in variable names >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Oct 05 13:30:14 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Manuel >Release: >Organization: >Environment: >Description: Please add dash (-) and plus (+) symbols to allowed characters in variable names: Dash symbols are required when using OptionsNG and $UNIQUENAME_SET/UNSET. e.g. apache22-event-mpm_SET=... Plus symbols can be used to extend existing variables. e.g. OPTIONS_SET+=... >How-To-Repeat: >Fix: --- /usr/local/libexec/portconf.orig 2012-10-05 14:47:42.000000000 +0200 +++ /usr/local/libexec/portconf 2012-10-05 15:14:08.000000000 +0200 @@ -36,7 +36,7 @@ sed '/^#/d;/^[[:space:]]*$/d' "${_conf}" | while read _line; do for _port in ${_line%%:*}; do if [ "${_pwd%%${_port}}" != "${_pwd}" ]; then - echo ${_line#*:} | sed -E 's/([A-Za-z0-9_]+)(=([^|]+))?/\1=\3/g;s/!([A-Za-z0-9_]+)=([^|]+)?/.undef \1/g;s/ *\| */|/g;s/ /%/g' + echo ${_line#*:} | sed -E 's/([A-Za-z0-9_\-]+\+?)(=([^|]+))?/\1=\3/g;s/!([A-Za-z0-9_]+)=([^|]+)?/.undef \1/g;s/ *\| */|/g;s/ /%/g' fi done done >Release-Note: >Audit-Trail: >Unformatted: