From owner-svn-src-all@FreeBSD.ORG Sun Mar 13 19:17:01 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01C0310656B6; Sun, 13 Mar 2011 19:17:01 +0000 (UTC) (envelope-from artemb@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6FB678FC16; Sun, 13 Mar 2011 19:17:00 +0000 (UTC) Received: by qwc9 with SMTP id 9so917633qwc.13 for ; Sun, 13 Mar 2011 12:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=WkTPEMjZy6bG46f1qppkHJFt8dcynklCe8tr9JjfUaU=; b=a7BhPqAFugp4Pg6/QfzeB5o9XEM1c/B5feWopf1ACUvIAyV/APD++5QugBpg5fgiDK LRhx5nkkmg+XfFT+l7vJHNiv/pT1Dc6ABOc1rxUGEgdkyijRd/kjbbwxnIAmmrU8e7vy vW+U2dP0r0VdTue/ABMWN9fb3WDawLuO1+oYQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=FPYyszL6H7GOkvDi4IbWSCpCc0XnQSeJLbWQG01TwXRpiRUGvir//y1Azo0HGdgLhi jWwA7KDsUeFbn0/ESexHrK7p/gICRX08Ztjjr9BUVMdHXEQjdN6lcXXSk0mNbKrreEZC cfdCwtIb0IxLl6sV6qbYc6B5wtuTz+vxnb9Kg= MIME-Version: 1.0 Received: by 10.229.98.195 with SMTP id r3mr9128383qcn.287.1300043819706; Sun, 13 Mar 2011 12:16:59 -0700 (PDT) Sender: artemb@gmail.com Received: by 10.229.31.83 with HTTP; Sun, 13 Mar 2011 12:16:59 -0700 (PDT) In-Reply-To: <20110313141528.000013b1@unknown> References: <201103120851.p2C8phoN010341@svn.freebsd.org> <20110312205719.00004e67@unknown> <20110313141528.000013b1@unknown> Date: Sun, 13 Mar 2011 12:16:59 -0700 X-Google-Sender-Auth: 8djVdcP9_zezgtzDq-w2D7y0WsY Message-ID: From: Artem Belevich To: Alexander Leidinger Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andriy Gapon Subject: Re: svn commit: r219559 - in head/sys: amd64/linux32 compat/freebsd32 i386/linux kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Mar 2011 19:17:01 -0000 On Sun, Mar 13, 2011 at 6:15 AM, Alexander Leidinger wrote: > On Sat, 12 Mar 2011 22:24:09 -0800 Artem Belevich > wrote: > >> >> Modified: head/sys/i386/linux/syscalls.master >> >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 l_h= andler_t handler); } >> >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 voi= d *handler); } >> > >> > What's wrong with l_handler_t? >> >> I don't recall the details, but I believe that the way l_handler_t is >> defined resulted in compilation errors in generated glue code. Glue >> generation code relies on '*' before the argument name in order to >> tell scalars from pointers. l_handler_t was interpreted as a scalar >> and on i386 where l_handler_t is a pointer, it produced compilation >> warning. > > What about documenting it with a comment nearby? How about this: handle is l_handle_t, but the makesyscalls.sh relies on '*' to tell pointers from scalars when it generates DTrace glue code, so void* had to be used. I don't have commit bit, though. --Artem