From owner-svn-src-head@FreeBSD.ORG  Mon Jun 13 06:27:58 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 026CA1065676;
	Mon, 13 Jun 2011 06:27:58 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail06.syd.optusnet.com.au (mail06.syd.optusnet.com.au
	[211.29.132.187])
	by mx1.freebsd.org (Postfix) with ESMTP id 61EAC8FC13;
	Mon, 13 Jun 2011 06:27:56 +0000 (UTC)
Received: from c122-106-165-191.carlnfd1.nsw.optusnet.com.au
	(c122-106-165-191.carlnfd1.nsw.optusnet.com.au [122.106.165.191])
	by mail06.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	p5D6Rn42028080
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 13 Jun 2011 16:27:51 +1000
Date: Mon, 13 Jun 2011 16:27:49 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Dimitry Andric <dim@freebsd.org>
In-Reply-To: <201106130104.p5D140VF048748@svn.freebsd.org>
Message-ID: <20110613161452.S843@besplex.bde.org>
References: <201106130104.p5D140VF048748@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r223029 - head/usr.sbin/makefs/ffs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2011 06:27:58 -0000

On Mon, 13 Jun 2011, Dimitry Andric wrote:

> Log:
>  Apparently makefs needs a few more system headers to compile during
>  buildworld.

This expands the bug.

> Modified:
>  head/usr.sbin/makefs/ffs/ffs_bswap.c
>  head/usr.sbin/makefs/ffs/ffs_subr.c
>
> Modified: head/usr.sbin/makefs/ffs/ffs_bswap.c
> ==============================================================================
> --- head/usr.sbin/makefs/ffs/ffs_bswap.c	Mon Jun 13 00:55:29 2011	(r223028)
> +++ head/usr.sbin/makefs/ffs/ffs_bswap.c	Mon Jun 13 01:04:00 2011	(r223029)
> @@ -35,6 +35,8 @@ __FBSDID("$FreeBSD$");
>
> #include <sys/param.h>
> #include <sys/queue.h>
> +#include <sys/lock.h>
> +#include <sys/lockmgr.h>
> #if defined(_KERNEL)
> #include <sys/systm.h>
> #endif

Kernel variables like sn_lock should not be exported to userland.  And
even when they are, the full kernel API for accessing them should not
by included by userland (or in kernel headers).  The system provides
headers <sys/_lock.h> and <sys/_lockmgr.h> to help avoid exposing the
full API.

These bugs are in many networking headers, but should not be added in
new code.  The networking headers are so convuluted and broken that
many of them have to expose the full API.  This should be even easier
to avoid adding in new code.

Bruce