From owner-svn-src-head@FreeBSD.ORG Fri Jan 23 21:06:00 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E15CEC4B; Fri, 23 Jan 2015 21:06:00 +0000 (UTC) Received: from smtp5.ore.mailhop.org (smtp5.ore.mailhop.org [54.186.10.118]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BD9B31F6; Fri, 23 Jan 2015 21:06:00 +0000 (UTC) Received: from [73.34.117.227] (helo=ilsoft.org) by smtp5.ore.mailhop.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1YElQP-0006jB-Gr; Fri, 23 Jan 2015 21:05:53 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t0NL5q0E018065; Fri, 23 Jan 2015 14:05:52 -0700 (MST) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX18AGm9qMkLHXui13aybAPZQ Message-ID: <1422047152.1038.25.camel@freebsd.org> Subject: Re: svn commit: r277570 - head/usr.bin/vmstat From: Ian Lepore To: Will Andrews Date: Fri, 23 Jan 2015 14:05:52 -0700 In-Reply-To: <20150123205617.GB56104@sol.firepipe.net> References: <201501231618.t0NGIeDv057991@svn.freebsd.org> <20150123205617.GB56104@sol.firepipe.net> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.8 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: Davide Italiano , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 21:06:01 -0000 On Fri, 2015-01-23 at 13:56 -0700, Will Andrews wrote: > On Fri, Jan 23, 2015 at 11:23:57AM -0800, Davide Italiano wrote: > > What's the rationale behind this change? > > The rationale was to match the clock used to the name (and implied intent) > of the variables used to store/manipulate the data. > > It's possible that 'uptime' is entirely the wrong term in vmstat, in which > case the naming used elsewhere in vmstat needs to be changed too. > It seems like there's a good chance this is a step backwards. In the old days if you wanted a monotonic clock, uptime was your only option. Eventually we implemented clock_gettime() and CLOCK_MONOTONIC and likely someone changed the calls in vmstat but perhaps not related variable names. So now we've gone back to the wrong clock to match the old variable names. (I don't see anything in the vmstat manpage about actually displaying or using uptime values at all.) -- Ian