From owner-p4-projects Fri Oct 4 5:49:57 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 01BE337B404; Fri, 4 Oct 2002 05:49:54 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8ECC337B401; Fri, 4 Oct 2002 05:49:54 -0700 (PDT) Received: from sentry.gw.tislabs.com (sentry.gw.tislabs.com [192.94.214.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD58743E3B; Fri, 4 Oct 2002 05:49:53 -0700 (PDT) (envelope-from cvance@tislabs.com) Received: by sentry.gw.tislabs.com; id IAA18505; Fri, 4 Oct 2002 08:49:45 -0400 (EDT) Received: from zorg.gw.tislabs.com(10.33.60.104) by sentry.gw.tislabs.com via smap (V5.5) id xma018489; Fri, 4 Oct 02 12:48:53 GMT Received: from localhost (cvance@localhost) by zorg.gw.tislabs.com (8.11.2/8.11.2) with ESMTP id g94Cl3x30870; Fri, 4 Oct 2002 08:47:03 -0400 X-Authentication-Warning: zorg.gw.tislabs.com: cvance owned process doing -bs Date: Fri, 4 Oct 2002 08:47:03 -0400 (EDT) From: Chris Vance X-X-Sender: To: Brian Feldman Cc: Perforce Change Reviews Subject: Re: PERFORCE change 18562 for review In-Reply-To: <200210022116.g92LG0VZ080199@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Actually I had it this way on purpose. In testing, not all filesystems will be mounted with extended attribute support (multilable). It seems unnecessary to make 100,000 calls to extattr_set_link() for those filesystems. Instead, label the system as: % sebsd_setfiles file_contexts / /home /usr/obj /usr/src chris. On Wed, 2 Oct 2002, Brian Feldman wrote: > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18562 > > Change 18562 by green@green_laptop_2 on 2002/10/02 14:15:51 > > It appears we really intend to label across filesystems, so > don't turn that off. > > Affected files ... > > .. //depot/projects/trustedbsd/mac/sbin/sebsd_setfiles/setfiles.c#5 edit > > Differences ... > > ==== //depot/projects/trustedbsd/mac/sbin/sebsd_setfiles/setfiles.c#5 (text+ko) ==== > > @@ -395,7 +395,7 @@ > fclose(fp); > > /* Walk the file tree, calling apply_spec on each file. */ > - fts = fts_open(fts_path, FTS_PHYSICAL | FTS_XDEV, NULL); > + fts = fts_open(fts_path, FTS_PHYSICAL, NULL); > while ((ftsent = fts_read(fts))) { > apply_spec(ftsent); > } > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message