From owner-freebsd-net@FreeBSD.ORG  Mon May 24 00:53:25 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A19FC16A4CE
	for <freebsd-net@freebsd.org>; Mon, 24 May 2004 00:53:25 -0700 (PDT)
Received: from n33.kp.t-systems-sfr.com (n33.kp.t-systems-sfr.com
	[129.247.16.33])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B3A7B43D53
	for <freebsd-net@freebsd.org>; Mon, 24 May 2004 00:53:24 -0700 (PDT)
	(envelope-from harti@freebsd.org)
Received: from n81.sp.op.dlr.de (n81g.sp.op.dlr.de [129.247.163.1])
	i4O7r6j96838;	Mon, 24 May 2004 09:53:06 +0200
Received: from zeus.nt.op.dlr.de (zeus.nt.op.dlr.de [129.247.173.3]) by
	n81.sp.op.dlr.de (AIX5.1/8.11.6p2/8.11.0) with ESMTP id i4O7r6K177946; Mon, 24
	May 2004 09:53:06 +0200
Received: from localhost (brandt@localhost)
	by zeus.nt.op.dlr.de (8.11.7+Sun/8.9.1) with ESMTP id i4O7r4010082;
	Mon, 24 May 2004 09:53:05 +0200 (MET DST)
X-Authentication-Warning: zeus.nt.op.dlr.de: brandt owned process doing -bs
Date: Mon, 24 May 2004 09:53:04 +0200 (MET DST)
From: Harti Brandt <harti@freebsd.org>
X-X-Sender: brandt@zeus
To: Dmitri Denissov <ddenissov@sandvine.com>
In-Reply-To: <FE045D4D9F7AED4CBFF1B3B813C85337012C0D56@mail.sandvine.com>
Message-ID: <Pine.GSO.4.60.0405240952150.9871@zeus>
References: <FE045D4D9F7AED4CBFF1B3B813C85337012C0D56@mail.sandvine.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-net@freebsd.org
Subject: Re: protecting netgraph calls from outside of the network context
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Harti Brandt <harti@freebsd.org>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 May 2004 07:53:25 -0000

On Thu, 20 May 2004, Dmitri Denissov wrote:

DD>Currently netgraph code uses splnet/splx to protect timeout calls.
DD>This doesn't work with 5.2 SMP kernel. What is the proper method 
DD>here for a custom netgraph node? Is the Giant lock only the way?

Have a lock at the ng_timeout/ng_untimeout functions in ng_base.c.
These should do the proper locking.

harti