From owner-freebsd-current@FreeBSD.ORG Tue Jan 16 18:39:37 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 452F216A4A7 for ; Tue, 16 Jan 2007 18:39:37 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184]) by mx1.freebsd.org (Postfix) with ESMTP id C30A213C45E for ; Tue, 16 Jan 2007 18:39:36 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by nf-out-0910.google.com with SMTP id k27so2474464nfc for ; Tue, 16 Jan 2007 10:39:35 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=UTl/lgoYGJ2QtrSspPNXs2Pu6MP12LIvOFcrKSpTvxH0QVu2e/wNYLuTKdn29pZXOskpwJmLNZt9vS77apI5Tv2dZJsIT+2/1wIrG7AAP7fDeusQk9Tz0EzhpCqTkCctUUWYI4dl31Z57JjH8GH+zQn64pRIB+DdOvAjpDpT9LY= Received: by 10.48.245.17 with SMTP id s17mr6333351nfh.1168972769649; Tue, 16 Jan 2007 10:39:29 -0800 (PST) Received: by 10.48.238.9 with HTTP; Tue, 16 Jan 2007 10:39:29 -0800 (PST) Message-ID: <3bbf2fe10701161039g4b1572a1qf8b97f2389b31a0e@mail.gmail.com> Date: Tue, 16 Jan 2007 19:39:29 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Julian Elischer" In-Reply-To: <45AD19B2.6010806@elischer.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <3bbf2fe10607250813w8ff9e34pc505bf290e71758@mail.gmail.com> <3bbf2fe10607250814m1a476f09p2d962dedc0c99be1@mail.gmail.com> <200607251232.51230.jhb@freebsd.org> <3bbf2fe10607251004wf94e238xb5ea7a31c973817f@mail.gmail.com> <3bbf2fe10607261127p3f01a6c3w80027754f7d4e594@mail.gmail.com> <3bbf2fe10607281004o6727e976h19ee7e054876f914@mail.gmail.com> <3bbf2fe10701160851r79b04464m2cbdbb7f644b22b6@mail.gmail.com> <45AD19B2.6010806@elischer.org> X-Google-Sender-Auth: dcfd126d2e293cf6 Cc: Kip Macy , freebsd-current@freebsd.org, Pawel Jakub Dawidek , Suleiman Souhlal , freebsd-arch@freebsd.org Subject: Re: [PATCH] Mantaining turnstile aligned to 128 bytes in i386 CPUs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2007 18:39:37 -0000 2007/1/16, Julian Elischer : > Attilio Rao wrote: > > 2006/7/28, Attilio Rao : > >> > >> After some thinking, I think it's better using init/fini methods > >> (since they hide the sizeof(struct turnstile) with size parameter). > >> > >> Feedbacks and comments are welcome: > >> http://users.gufi.org/~rookie/works/patches/uma_sync_init.diff > > > > [CC'ed all the interested people] > > > > Even if a long time is passed I did some benchmarks based on ebizzy tool. > > This program claims to reproduce a real httpd server behaviour and is > > used into the Linux world for benchmarks, AFAIK. > > I think that results of the comparison on this patch is very > > interesting, and I think it worths a commit :) > > I think that results can be even better on a Xeon machine (I had no > > chance to reproduce this on some of these). > > (Results taken in consideration have been measured after some starts, > > in order to minimize caching differences). > > > > The patch: > > http://users.gufi.org/~rookie/works/patches/ts-sq/ts-sq.diff > > > > The benchmark results: > > http://users.gufi.org/~rookie/works/patches/ts-sq/ts-sq.benchmark > > those are very big differences! > what does the benchmark actually measure? just time ./ebizzy (which create a lot of contention inside the kernel). Attilio -- Peace can only be achieved by understanding - A. Einstein