From owner-p4-projects  Fri Oct  4 21:37:36 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id AD68F37B404; Fri,  4 Oct 2002 21:37:34 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 31A8537B401; Fri,  4 Oct 2002 21:37:34 -0700 (PDT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A6AE743E4A; Fri,  4 Oct 2002 21:37:33 -0700 (PDT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3])
	by fledge.watson.org (8.12.4/8.12.4) with SMTP id g954b6Oo076744;
	Sat, 5 Oct 2002 00:37:06 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Sat, 5 Oct 2002 00:37:05 -0400 (EDT)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: Brian Feldman <green@FreeBSD.org>
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 18663 for review
In-Reply-To: <200210041456.g94Eu33e081725@freefall.freebsd.org>
Message-ID: <Pine.NEB.3.96L.1021005003608.64999b-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG


You probably want to add an XXXMAC in the comment there, since this will
be fixed soon (I hope).

On Fri, 4 Oct 2002, Brian Feldman wrote:

> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18663
> 
> Change 18663 by green@green_laptop_2 on 2002/10/04 07:55:58
> 
> 	Reject, not crash on, files currently invalid to have extended
> 	attributes on.
> 
> Affected files ...
> 
> .. //depot/projects/trustedbsd/mac/sys/ufs/ffs/ffs_vnops.c#12 edit
> 
> Differences ...
> 
> ==== //depot/projects/trustedbsd/mac/sys/ufs/ffs/ffs_vnops.c#12 (text+ko) ====
> 
> @@ -1402,6 +1402,19 @@
>  	struct ufs2_dinode *dp;
>  	int error;
>  
> +	/*
> +	 * Since these inode types don't contain storage, their vnode
> +	 * operations don't include the strategy() necessary for EA on
> +	 * UFS2 right now.
> +	 */
> +	switch (vp->v_type) {
> +	case VCHR:
> +	case VBLK:
> +	case VFIFO:
> +		return (EFTYPE);
> +	default:
> +		break;
> +	}
>  	ip = VTOI(vp);
>  	fs = ip->i_fs;
>  
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message