From owner-svn-src-head@FreeBSD.ORG Mon Sep 29 11:10:34 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 65DAB2C4; Mon, 29 Sep 2014 11:10:34 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "tensor.andric.com", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2317D8B5; Mon, 29 Sep 2014 11:10:33 +0000 (UTC) Received: from [192.168.2.2] (unknown [77.243.161.229]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 4863FB80A; Mon, 29 Sep 2014 13:10:23 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_0F40BEA6-9BCE-433B-932A-5B2C79865E07"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r272281 - head/lib/libpam/modules/pam_login_access From: Dimitry Andric In-Reply-To: <201409291036.s8TAaFUs040310@svn.freebsd.org> Date: Mon, 29 Sep 2014 13:10:03 +0200 Message-Id: References: <201409291036.s8TAaFUs040310@svn.freebsd.org> To: "Bjoern A. Zeeb" X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Sep 2014 11:10:34 -0000 --Apple-Mail=_0F40BEA6-9BCE-433B-932A-5B2C79865E07 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 29 Sep 2014, at 12:36, Bjoern A. Zeeb wrote: > Author: bz > Date: Mon Sep 29 10:36:14 2014 > New Revision: 272281 > URL: http://svnweb.freebsd.org/changeset/base/272281 >=20 > Log: > Hopefully fix build breakage with gcc passing void * instead of char = * > to "%s" format string after r272280. >=20 > PR: 83099 193927 > MFC after: 3 days > X-MFC with: r272280 >=20 > Modified: > head/lib/libpam/modules/pam_login_access/pam_login_access.c >=20 > Modified: head/lib/libpam/modules/pam_login_access/pam_login_access.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/lib/libpam/modules/pam_login_access/pam_login_access.c = Mon Sep 29 08:57:36 2014 (r272280) > +++ head/lib/libpam/modules/pam_login_access/pam_login_access.c = Mon Sep 29 10:36:14 2014 (r272281) > @@ -94,7 +94,8 @@ pam_sm_acct_mgmt(pam_handle_t *pamh, int > PAM_VERBOSE_ERROR("%s is not allowed to log in on %s", > user, tty); > } else { > - PAM_LOG("Checking login.access for user %s", user); > + PAM_LOG("Checking login.access for user %s", > + (const char *)user); > if (login_access(user, "***unknown***") !=3D 0) > return (PAM_SUCCESS); > PAM_VERBOSE_ERROR("%s is not allowed to log in", user); >=20 Just a few lines after the one you fixed it accesses the same variable again. Why doesn't it warn there? And why is 'user' not a char * to begin with? :) -Dimitry --Apple-Mail=_0F40BEA6-9BCE-433B-932A-5B2C79865E07 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlQpPhMACgkQsF6jCi4glqMoYgCglBL1qvCzvB7RQrk6+TeQPD5X QmYAoNqkqv091P3gB46nRccVyKQZ9EDh =oeTD -----END PGP SIGNATURE----- --Apple-Mail=_0F40BEA6-9BCE-433B-932A-5B2C79865E07--