From owner-freebsd-fs@FreeBSD.ORG Fri Dec 23 11:29:52 2011 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AA9451065670 for ; Fri, 23 Dec 2011 11:29:52 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 5B9C28FC08 for ; Fri, 23 Dec 2011 11:29:52 +0000 (UTC) Received: from localhost (58.wheelsystems.com [83.12.187.58]) by mail.dawidek.net (Postfix) with ESMTPSA id 71DB23D9; Fri, 23 Dec 2011 12:29:49 +0100 (CET) Date: Fri, 23 Dec 2011 12:28:46 +0100 From: Pawel Jakub Dawidek To: Ed Schouten Message-ID: <20111223112846.GA1679@garage.freebsd.pl> References: <20111222214728.GV1771@hoeg.nl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+HP7ph2BbKc20aGI" Content-Disposition: inline In-Reply-To: <20111222214728.GV1771@hoeg.nl> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-fs@FreeBSD.org Subject: Re: Changing refcount(9) to use a refcount_t X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2011 11:29:52 -0000 --+HP7ph2BbKc20aGI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 22, 2011 at 10:47:28PM +0100, Ed Schouten wrote: > The reason why I'm emailing this to fs@, is because this change breaks > one of the existing file system drivers, namely ZFS. Solaris also > implements a refcount_t, but unlike FreeBSD's, it has a more complex API > and is 64-bits in size. Still, I suspect it's hard to overflow a 32-bit > reference counter, right? Even if it is, we can fix this in the long run > by making refcount_t a truly opaque object of type u_long. >=20 > Can any of you ZFS user please try the following patch? Do any of you > object if I commit it to SVN and merge it in a couple of months from > now? Ed, what is the purpose of the patch exactly? Is there no way to keep ZFS as it is? Will it stop compile? Even with -std=3Dc99? You changing here vendor code and we still don't want to do that if avoidable, as we want to share code with IllumOS. Unless I see strong reasons why this is unavoidable, I do object. If that was our own code, reducing it would be definiately welcome, but because we share the code, we will just grow the diff against other ZFS versions out there. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --+HP7ph2BbKc20aGI Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk70Ze4ACgkQForvXbEpPzRm9ACfaa5XOqHJPeUOZgXo8LdV0YzA UGIAn3De/RYA7ct4TlMlZUVy4cT1LmZh =87F9 -----END PGP SIGNATURE----- --+HP7ph2BbKc20aGI--