From owner-cvs-all@FreeBSD.ORG Fri Apr 6 13:11:32 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 033B216A401; Fri, 6 Apr 2007 13:11:32 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 5B9E613C457; Fri, 6 Apr 2007 13:11:31 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.8/8.13.8) with ESMTP id l36DBT6g091443; Fri, 6 Apr 2007 17:11:29 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.8/8.13.8/Submit) id l36DBSdI091442; Fri, 6 Apr 2007 17:11:28 +0400 (MSD) (envelope-from ache) Date: Fri, 6 Apr 2007 17:11:28 +0400 From: Andrey Chernov To: Pawel Jakub Dawidek Message-ID: <20070406131127.GA91320@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Pawel Jakub Dawidek , Bruce Evans , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200704052110.l35LAsXH013966@repoman.freebsd.org> <20070406115326.A43678@delplex.bde.org> <20070406053934.GA84722@nagual.pp.ru> <20070406103519.GA1251@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: <20070406103519.GA1251@garage.freebsd.pl> User-Agent: Mutt/1.5.14 (2007-02-12) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Bruce Evans Subject: Re: cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2007 13:11:32 -0000 --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 06, 2007 at 12:35:19PM +0200, Pawel Jakub Dawidek wrote: > > > These are just namespace pollution in stdio.h. stdio (fseek()) doesn= 't > > > support them, and the hack of declaring lseek() in stdio.h should not > > > be extended to new interfaces. If stdio ever supports them, then they > > > would need to be declared under a visibility ifdef (not #ifdef self). > >=20 > > I agree. They must be implemented in fseek.c code first before adding t= hem=20 > > to stdio.h and ifdefed with proper *_VISIBLE tags in all places. > > Perhaps new __CDDL_VISIBLE tag required for it. >=20 > This is not CDDL licensed. I'm planning to implement support for > SEEK_DATA and SEEK_HOLE for UFS. This is not matter of license at all but matter of standards conformance. Feel free to invent any other __*_VISIBLE tag to exclude this addition=20 =66rom namespace for programs which may define their own SEEK_DATA etc=20 which is allowed f.e. in POSIX namespace. Look like other __*_VISIBLE tags= =20 are implemented and what they does. Default is turn all on. In any case adding them to stdio.h is premature action - I not see yet corresponding fseek() code. --=20 http://ache.pp.ru/ --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGFkb/Vg5YK5ZEdN0RAmsEAJ9lwWP8RjRfqrgmtrWHQJmgvT6xKQCgqInC NBrexJjV5KcOXF6PHeb2mmM= =CHDV -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--