From owner-svn-src-all@FreeBSD.ORG Sun Apr 27 18:12:56 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7D5E176A; Sun, 27 Apr 2014 18:12:56 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6A3851209; Sun, 27 Apr 2014 18:12:56 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s3RICuoY071516; Sun, 27 Apr 2014 18:12:56 GMT (envelope-from ian@svn.freebsd.org) Received: (from ian@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s3RICunl071515; Sun, 27 Apr 2014 18:12:56 GMT (envelope-from ian@svn.freebsd.org) Message-Id: <201404271812.s3RICunl071515@svn.freebsd.org> From: Ian Lepore Date: Sun, 27 Apr 2014 18:12:56 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r265020 - head/sys/arm/include X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Apr 2014 18:12:56 -0000 Author: ian Date: Sun Apr 27 18:12:55 2014 New Revision: 265020 URL: http://svnweb.freebsd.org/changeset/base/265020 Log: Remove cpu_idcache_wbinv_all() from kdb_cpu_trap(), it's no longer needed. This was added ca. 2004 for the purpose of ensuring the caches were in the right state after the debugger set a breakpoint. kdb_cpu_sync_icache() was added in 2007 to handle that situation, and now the wbinv_all is actually harmful because the operation isn't broadcast to other cores. Modified: head/sys/arm/include/kdb.h Modified: head/sys/arm/include/kdb.h ============================================================================== --- head/sys/arm/include/kdb.h Sun Apr 27 17:41:18 2014 (r265019) +++ head/sys/arm/include/kdb.h Sun Apr 27 18:12:55 2014 (r265020) @@ -55,8 +55,6 @@ kdb_cpu_sync_icache(unsigned char *addr, static __inline void kdb_cpu_trap(int type, int code) { - - cpu_idcache_wbinv_all(); } #endif /* _MACHINE_KDB_H_ */