From owner-freebsd-geom@FreeBSD.ORG Tue Jul 27 17:06:44 2010 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 220261065676; Tue, 27 Jul 2010 17:06:44 +0000 (UTC) (envelope-from marius@nuenneri.ch) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 757378FC20; Tue, 27 Jul 2010 17:06:43 +0000 (UTC) Received: by fxm13 with SMTP id 13so784301fxm.13 for ; Tue, 27 Jul 2010 10:06:42 -0700 (PDT) Received: by 10.239.156.10 with SMTP id k10mr619152hbc.147.1280250402479; Tue, 27 Jul 2010 10:06:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.239.137.139 with HTTP; Tue, 27 Jul 2010 10:06:18 -0700 (PDT) In-Reply-To: References: <4C4ED619.7050305@FreeBSD.org> <27237.1280241532@critter.freebsd.dk> From: =?UTF-8?Q?Marius_N=C3=BCnnerich?= Date: Tue, 27 Jul 2010 19:06:18 +0200 Message-ID: To: Poul-Henning Kamp Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Alexander Motin , freebsd-geom@freebsd.org Subject: Re: Hyperactive g_event thread X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2010 17:06:44 -0000 On Tue, Jul 27, 2010 at 18:07, Marius N=C3=BCnnerich w= rote: > On Tue, Jul 27, 2010 at 16:38, Poul-Henning Kamp wro= te: >> In message <4C4ED619.7050305@FreeBSD.org>, Alexander Motin writes: >>>Poul-Henning Kamp wrote: >> >>>I have already removed alike timeouts on up/down threads and it indeed >>>was safe there. But are you really sure about this specific case? Cause >>>I'm not. Up/down threads using msleep and checking lack of work after >>>dropping/grabbing lock. Event thread instead does several tasks, drops >>>lock few times between them and uses tsleep(). I would say there should >>>be a bunch of race conditions. >> >> Quite likely, I didn't say it would be a trivial thing to remove >> that workaround :-) > > Hi, > > I was running with a patch that removed the timeout for a while like 2 > years ago. Albeit not with high load. Worked fine at that time, I will > search for the patch when I'm back home later today. > > =C2=A0- Marius > Here it is: http://lists.freebsd.org/pipermail/freebsd-geom/2008-December/003200.html The mail is quite old now, I don't know if the patch still applies. Will check that if I can find the time. I would be happy to see this committed after all this time :)