From owner-svn-src-all@FreeBSD.ORG Fri Apr 2 09:56:23 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A1ED106564A; Fri, 2 Apr 2010 09:56:23 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 53A6E8FC0C; Fri, 2 Apr 2010 09:56:23 +0000 (UTC) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 075A646B03; Fri, 2 Apr 2010 05:56:23 -0400 (EDT) Date: Fri, 2 Apr 2010 10:56:22 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Alexander Leidinger In-Reply-To: <201004020655.o326tWax079882@svn.freebsd.org> Message-ID: References: <201004020655.o326tWax079882@svn.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r206082 - in head: . share/man/man7 share/mk sys/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 09:56:23 -0000 On Fri, 2 Apr 2010, Alexander Leidinger wrote: > WITH_CTF can now be specified in src.conf (not recommended, there > are some problems with static executables), make.conf (would also > affect ports which do not use GNU make and do not override the > compile targets) or in the kernel config (via "makeoptions > WITH_CTF=yes"). > > Additional (related) changes: > - propagate WITH_CTF to module builds > - do not add -g to the linker flags, it's a noop there anyway > (at least according to the man page of ld) > - do not add -g to CFLAGS unconditionally > we need to have a look if it is really needed (IMO not) or if there > is a way to add it only when WITH_CTF is used > > Note: ctfconvert / ctfmerge lines will not appear in the build output, > to protect the innocent (those which do not build with WITH_CTF would > see the shell-test and may think WITH_CTF is used). Excellent -- I'm really glad to see this getting sorted out at last. I think there's a reasonable argument that we should be compiling options KDTRACE_HOOKS into GENERIC, and likewise enabling CTF on the kernel by default in 9.x. Part of the point of DTrace is that it "just works", and we already compile CDDL modules by default (and the hooks don't affect the license of the base kernel as far as I'm aware). Any thoughts on this? Robert