From owner-p4-projects  Mon Oct  7 14:18: 4 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 783F737B404; Mon,  7 Oct 2002 14:18:00 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 24DAB37B401
	for <perforce@freebsd.org>; Mon,  7 Oct 2002 14:18:00 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D1BE543E4A
	for <perforce@freebsd.org>; Mon,  7 Oct 2002 14:17:59 -0700 (PDT)
	(envelope-from green@freebsd.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g97LHxCo068314
	for <perforce@freebsd.org>; Mon, 7 Oct 2002 14:17:59 -0700 (PDT)
	(envelope-from green@freebsd.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g97LHxjd068311
	for perforce@freebsd.org; Mon, 7 Oct 2002 14:17:59 -0700 (PDT)
Date: Mon, 7 Oct 2002 14:17:59 -0700 (PDT)
Message-Id: <200210072117.g97LHxjd068311@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to green@freebsd.org using -f
From: Brian Feldman <green@FreeBSD.org>
Subject: PERFORCE change 18887 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18887

Change 18887 by green@green_laptop_2 on 2002/10/07 14:17:17

	Add an -n flag to setextattr(8): nul-terminate the extent (like
	what SEBSD wants).

Affected files ...

.. //depot/projects/trustedbsd/mac/usr.sbin/extattr/rmextattr.8#3 edit
.. //depot/projects/trustedbsd/mac/usr.sbin/extattr/rmextattr.c#5 edit

Differences ...

==== //depot/projects/trustedbsd/mac/usr.sbin/extattr/rmextattr.8#3 (text+ko) ====

@@ -56,7 +56,7 @@
 .Ar attrname
 .Ar filename ...
 .Nm setextattr
-.Op Fl fq
+.Op Fl fnq
 .Ar attrnamespace
 .Ar attrname
 .Ar attrvalue
@@ -86,6 +86,8 @@
 .It Fl -f
 (Force) Ignore errors on individual filenames and continue with
 the remaining arguments.
+.It Fl -n
+(Nul-terminate) Nul-terminate the extent content written out.
 .It Fl -q
 (Quiet) Do not print out the pathname and suppress error messages.
 .It Fl -s

==== //depot/projects/trustedbsd/mac/usr.sbin/extattr/rmextattr.c#5 (text+ko) ====

@@ -62,7 +62,7 @@
 		fprintf(stderr, " attrname filename ...\n");
 		exit(-1);
 	case EASET:
-		fprintf(stderr, "usage: setextattr [-fq] attrnamespace");
+		fprintf(stderr, "usage: setextattr [-fnq] attrnamespace");
 		fprintf(stderr, " attrname attrvalue filename ...\n");
 		exit(-1);
 	case EARM:
@@ -106,6 +106,7 @@
 		 minargc;
 
 	int	flag_force = 0;
+	int	flag_null = 0;
 	int	flag_quiet = 0;
 	int	flag_string = 0;
 	int	flag_hex = 0;
@@ -122,7 +123,7 @@
 		minargc = 3;
 	} else if (!strcmp(p, "setextattr")) {
 		what = EASET;
-		options = "fq";
+		options = "fnq";
 		minargc = 4;
 	} else if (!strcmp(p, "rmextattr")) {
 		what = EARM;
@@ -141,6 +142,9 @@
 		case 'f':
 			flag_force = 1;
 			break;
+		case 'n':
+			flag_null = 1;
+			break;
 		case 'q':
 			flag_quiet = 1;
 			break;
@@ -190,7 +194,8 @@
 			break;
 		case EASET:
 			error = extattr_set_link(argv[arg_counter],
-			    attrnamespace, attrname, buf, strlen(buf));
+			    attrnamespace, attrname, buf,
+			    strlen(buf) + flag_null);
 			if (error >= 0)
 				continue;
 			break;

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message