From owner-freebsd-ports@FreeBSD.ORG Wed May 11 06:19:06 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B877716A4CE for ; Wed, 11 May 2005 06:19:06 +0000 (GMT) Received: from jengal.datamax.bg (jengal.datamax.bg [82.103.104.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3823C43D2D for ; Wed, 11 May 2005 06:19:06 +0000 (GMT) (envelope-from vd@datamax.bg) Received: from sinanica.bg.datamax (sinanica.bg.datamax [192.168.10.1]) by jengal.datamax.bg (Postfix) with QMQP id 26ED487C8 for ; Wed, 11 May 2005 09:19:05 +0300 (EEST) Received: (nullmailer pid 74303 invoked by uid 1004); Wed, 11 May 2005 06:19:05 -0000 Date: Wed, 11 May 2005 09:19:05 +0300 From: Vasil Dimov To: freebsd-ports@freebsd.org Message-ID: <20050511061904.GA74141@sinanica.bg.datamax> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Pd0ReVV5GZGQvF3a" Content-Disposition: inline X-OS: FreeBSD 5.4-STABLE User-Agent: Mutt/1.5.9i Subject: add-plist-info and add-plist-post targets in bsd.port.mk X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: vd@datamax.bg List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2005 06:19:06 -0000 --Pd0ReVV5GZGQvF3a Content-Type: multipart/mixed; boundary="6c2NcOVqGQ03X4Wi" Content-Disposition: inline --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Is there any reason add-plist-info and add-plist-post targets in bsd.port.mk are not surrounded by .if !target(...) ... .endif ? Shouldn't they be like the others laying around - add-plist-docs and generate-plist? I noticed that because of the warning caused by devel/mingw32-binutils. This port has redefined add-plist-post target and it seems that there is no easy way for it to do the things it need in any other way. It needs to append some dirrm commands at the end of the plist file AFTER automatically added install-info --delete commands. How could the be achieved without ugly hacks like redefining add-plist-docs? sinanica:/usr/ports/devel/mingw32-binutils# make describe "/usr/ports/Mk/bsd.port.mk", line 4847: warning: duplicate script for target "add-plist-post" ignored ... --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="bsd.port.mk.patch" Content-Transfer-Encoding: quoted-printable --- bsd.port.mk.orig Tue May 10 17:15:42 2005 +++ bsd.port.mk Wed May 11 09:05:11 2005 @@ -4819,6 +4819,7 @@ .endif .endif =20 +.if !target(add-plist-info) add-plist-info: # Process GNU INFO files at package install/deinstall time .if defined(INFO) @@ -4837,14 +4838,17 @@ .endif .endif .endif +.endif =20 # If we're installing into a non-standard PREFIX, we need to remove that d= irectory at # deinstall-time +.if !target(add-plist-post) add-plist-post: .if (${PREFIX} !=3D ${LOCALBASE} && ${PREFIX} !=3D ${X11BASE} && ${PREFIX}= !=3D ${LINUXBASE} && ${PREFIX} !=3D "/usr") @${ECHO_CMD} "@unexec rmdir %D 2> /dev/null || true" >> ${TMPPLIST} .else @${DO_NADA} +.endif .endif =20 .if !target(install-rc-script) --6c2NcOVqGQ03X4Wi-- --Pd0ReVV5GZGQvF3a Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- iD8DBQFCgaPYFw6SP/bBpCARAknCAKDQ7E9WVp8wZpswHmfUPJ5qyCF7zgCfbslo 3o6jZ7TcdEkDUFsuWC8NoIQ= =rvMQ -----END PGP SIGNATURE----- --Pd0ReVV5GZGQvF3a--