From owner-freebsd-arch@FreeBSD.ORG Sat Aug 23 02:06:39 2008 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF256106564A for ; Sat, 23 Aug 2008 02:06:39 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.230]) by mx1.freebsd.org (Postfix) with ESMTP id 71A9B8FC16 for ; Sat, 23 Aug 2008 02:06:39 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by wx-out-0506.google.com with SMTP id h27so296920wxd.7 for ; Fri, 22 Aug 2008 19:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=NaDmxiKtwE9BfdlBWr49Vt2J4gB6LSypWpXDVuXOVss=; b=dxLKePNMtqva3bVKiz0x/uEgM/rmp4m2bUJYeF8tcAJIZ0LLdt31h4B4B9vjUwJv2S lx5wYpryCBbVHNDIVGXjUhr8NQi5xOyFE2d+A2pDeTRXB39/0X1X679jnv/xih1s7g+8 Y1DMjfnEdeGjy2Idcd8hQkZvpTJAbbyZ1HMFQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=SUuVdxNTV8hN35RRcWpR5ggM/dcNQwtxHSaUhWipjLd+sei24aF0JGVO/qQvBB5BeA YAz7pqjOwrCNHcfGSS4Zos0K2joL8ViExpnsfWN9KLOHtUyEk90/RVQQdCJBLZ3GfjvO d5h2GMw3k3fzMR3Az/8PYubNhT8Vbab5gi4q0= Received: by 10.70.62.14 with SMTP id k14mr2183772wxa.33.1219455323554; Fri, 22 Aug 2008 18:35:23 -0700 (PDT) Received: from kan.dnsalias.net ( [24.63.237.22]) by mx.google.com with ESMTPS id 5sm3314676wrh.24.2008.08.22.18.35.21 (version=SSLv3 cipher=RC4-MD5); Fri, 22 Aug 2008 18:35:22 -0700 (PDT) Date: Fri, 22 Aug 2008 21:35:05 -0400 From: Alexander Kabaev To: arch@freebsd.org Message-ID: <20080822213505.1993beda@kan.dnsalias.net> In-Reply-To: <20080729.161303.709402272.imp@bsdimp.com> References: <20080729.161303.709402272.imp@bsdimp.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.11; i386-portbld-freebsd8.0) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/LY35jMM_18gg9vFRUyS.xIL"; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: kan@freebsd.org Subject: Re: Need a code review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Aug 2008 02:06:39 -0000 --Sig_/LY35jMM_18gg9vFRUyS.xIL Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 29 Jul 2008 16:13:03 -0600 (MDT) "M. Warner Losh" wrote: > Greetings, >=20 > The FreeBSD/mips efforts are getting close. We're down to 4 patches > against the main tree, divided up among different programs: cc, > binutils, libpam and the CDDL stuff for zfs. >=20 > http://people.freebsd.org/~gonzo/mips2/binutils.diff > http://people.freebsd.org/~gonzo/mips2/cc.diff > http://people.freebsd.org/~gonzo/mips2/cddl.diff > http://people.freebsd.org/~gonzo/mips2/libpam.diff >=20 > If you have an interest in any of these area, or would like to provide > feedback on the patches, now would be a good time to do so. :-) >=20 > We'd like to commit these patches to the tree by the end of next week, > if at all possible. If you are a maintainer of this software, we'd > especially like to get feedback from you on these patches. If we > don't hear back from you, we'll assume that you are fine with them :-) >=20 > Warner cc.diff part is OK, except that files we copy from vendor intact should be marked as such. Ideally, by putting their pristine versions in /vendor and branching into head/src/contrib/gcc. Some comments in new FreeBSD files still claim they are for NetBSD/mips. +#ifdef HANDLE_PRAGMA_PACK_PUSH_POP +#undef HANDLE_PRAGMA_PACK_PUSH_POP +#endif #define HANDLE_PRAGMA_PACK_PUSH_POP 1 Can this be rewritten as #ifndef HANDLE_PRAGMA_PACK_PUSH_POP #define HANDLE_PRAGMA_PACK_PUSH_POP 1 #endif ? --=20 Alexander Kabaev --Sig_/LY35jMM_18gg9vFRUyS.xIL Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFIr2lJQ6z1jMm+XZYRAjj4AJ9wl3y3m6hIaGDn7mvE1B3cW6zp6ACdERA4 cyoxTf9gZ7qWJq/+vlx3KSE= =1cSI -----END PGP SIGNATURE----- --Sig_/LY35jMM_18gg9vFRUyS.xIL--