From owner-p4-projects@FreeBSD.ORG  Mon Nov  3 21:53:31 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DF5EB106567B; Mon,  3 Nov 2008 21:53:30 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A26851065670
	for <perforce@freebsd.org>; Mon,  3 Nov 2008 21:53:30 +0000 (UTC)
	(envelope-from peter-gmail@wemm.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 90C138FC18
	for <perforce@freebsd.org>; Mon,  3 Nov 2008 21:53:30 +0000 (UTC)
	(envelope-from peter-gmail@wemm.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mA3LrUsO057655
	for <perforce@freebsd.org>; Mon, 3 Nov 2008 21:53:30 GMT
	(envelope-from peter-gmail@wemm.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mA3LrUre057653
	for perforce@freebsd.org; Mon, 3 Nov 2008 21:53:30 GMT
	(envelope-from peter-gmail@wemm.org)
Date: Mon, 3 Nov 2008 21:53:30 GMT
Message-Id: <200811032153.mA3LrUre057653@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	peter-gmail@wemm.org using -f
From: Peter Wemm <peter@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 152429 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Nov 2008 21:53:31 -0000

http://perforce.freebsd.org/chv.cgi?CH=152429

Change 152429 by peter@peter_overcee on 2008/11/03 21:53:10

	something in the toolchain on amd64 seems to generate call frame records
	that point to slightly before where valgrind things the text segment started.
	I assume this is PLT or something else.  Ignore it for now.  I don't think
	it can lead to the overlaps that the invariant checks are worried about.

Affected files ...

.. //depot/projects/valgrind/coregrind/m_debuginfo/debuginfo.c#7 edit

Differences ...

==== //depot/projects/valgrind/coregrind/m_debuginfo/debuginfo.c#7 (text+ko) ====

@@ -523,8 +523,11 @@
    di2 = NULL;
    /* invariant (2) */
    if (di->cfsi) {
+//VG_(printf)("cfsi_minavma %#lx cfsi_maxavma %#lx rx_map_avma %#lx rx_map_size %#lx end %#lx\n", di->cfsi_minavma, di->cfsi_maxavma, di->rx_map_avma, di->rx_map_size, di->rx_map_avma + di->rx_map_size);
       vg_assert(di->cfsi_minavma <= di->cfsi_maxavma); /* duh! */
+#if !defined(VGP_amd64_freebsd)	/* gcc does something wierd here */
       vg_assert(di->cfsi_minavma >= di->rx_map_avma);
+#endif
       vg_assert(di->cfsi_maxavma < di->rx_map_avma + di->rx_map_size);
    }
    /* invariants (3) and (4) */