From owner-freebsd-ports@FreeBSD.ORG  Wed Jan  3 19:27:49 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@freebsd.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B9B7916A407
	for <ports@freebsd.org>; Wed,  3 Jan 2007 19:27:49 +0000 (UTC)
	(envelope-from infofarmer@gmail.com)
Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.173])
	by mx1.freebsd.org (Postfix) with ESMTP id 2ABD813C442
	for <ports@freebsd.org>; Wed,  3 Jan 2007 19:27:49 +0000 (UTC)
	(envelope-from infofarmer@gmail.com)
Received: by ug-out-1314.google.com with SMTP id o2so4659174uge
	for <ports@freebsd.org>; Wed, 03 Jan 2007 11:27:48 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
	b=OL0q/JqkALvtOWYmlwJkbwyNJiQte3B7eR01wpi+yEHJxcM6ZdjLh0xBLjV7WC7ZE6HmXxQ8kw2GWcmze9r6Dh/tuU1DQPMV9R3kgRpWukM2dgLjzli62VVTpR4VlFKvP7sLDhpO2BMxIxWhWpZ7JKgSZV3Q21GYgVdd7f/vVwQ=
Received: by 10.78.118.19 with SMTP id q19mr2323043huc.1167850757759;
	Wed, 03 Jan 2007 10:59:17 -0800 (PST)
Received: by 10.78.164.20 with HTTP; Wed, 3 Jan 2007 10:59:17 -0800 (PST)
Message-ID: <cb5206420701031059u3b87c074kb82645afdc428b05@mail.gmail.com>
Date: Wed, 3 Jan 2007 21:59:17 +0300
From: "Andrew Pantyukhin" <infofarmer@FreeBSD.org>
Sender: infofarmer@gmail.com
To: "Gabor Kovesdan" <gabor@freebsd.org>
In-Reply-To: <459ADFF6.9050105@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200701011956.14607.freebsd@alaskaparadise.com>
	<200701021418.18003.jonas@schiebtsich.net>
	<200701021327.42947.freebsd@alaskaparadise.com>
	<459ADFF6.9050105@FreeBSD.org>
X-Google-Sender-Auth: 049cab5a9ae2d361
Cc: freebsd@alaskaparadise.com, ports@freebsd.org,
	Wesley Shields <wxs@atarininja.org>
Subject: Re: PLIST_FILES question
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jan 2007 19:27:49 -0000

On 1/3/07, Gabor Kovesdan <gabor@freebsd.org> wrote:
> Beech Rintoul schrieb:
> > Thanks to everyone who responded. I somehow missed that handbook section, but
> > I have it figured out now. What I needed to do is the following:
> >
> > .if defined(WITH_MYSQL)
> > USE_MYSQL=    yes
> > MODULES:=${MODULES}:mod_sql:mod_sql_mysql
> > INCLUDEDIRS:=${INCLUDEDIRS}:${LOCALBASE}/include
> > LIBDIRS:=${LIBDIRS}:${LOCALBASE}/lib/mysql
> > PLIST_FILES=  include/proftpd/mod_sql.h
> > .endif
> >
> > The  extra header file is not copied to include unless that option is checked
> > and hard coding it in pkg-plist broke the pkg build. It didn't show up on
> > pointyhat because that option is off by default.
> >
> >
>
> Oh, do you want to mix PLIST_FILES and pkg-plist, did
> I catch it right? That should not be done.

Why not?

> You can list that file in pkg-plist as
> %%MYSQL%%include/proftpd/mod_sql.h and do the following in Makefile:
>
> if defined(WITH_MYSQL)
> PLIST_SUB+= MYSQL=""
> [...another things here...]
> .else
>
> PLIST_SUB+= MYSQL="@comment "
> .endif
>
> Look at e.g. security/amavisd-new, I do something similar there.

PLIST_FILES is a bit simpler to use. Personal feelings
about the variable, or whether it smells well when mixed
with pkg-plist are interesting, but they are not quite
relevant if there's no technical problem.