From owner-freebsd-current@FreeBSD.ORG Sat Apr 17 17:01:09 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BAE5C16A4D2 for ; Sat, 17 Apr 2004 17:01:09 -0700 (PDT) Received: from sccrmhc12.comcast.net (sccrmhc12.comcast.net [204.127.202.56]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CE2A43D41 for ; Sat, 17 Apr 2004 17:01:09 -0700 (PDT) (envelope-from adam@migus.org) Received: from ganyopa.migus.org ([68.55.142.251]) by comcast.net (sccrmhc12) with ESMTP id <20040418000104012001d5k4e>; Sun, 18 Apr 2004 00:01:08 +0000 Received: from localhost (localhost [127.0.0.1]) by ganyopa.migus.org (Postfix) with ESMTP id 7D82B4D46C; Sat, 17 Apr 2004 20:00:59 -0400 (EDT) Received: from ganyopa.migus.org ([127.0.0.1]) by localhost (ganyopa.migus.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id 14335-09; Sat, 17 Apr 2004 20:00:59 -0400 (EDT) Received: by ganyopa.migus.org (Postfix, from userid 72) id CB1874C1C4; Sat, 17 Apr 2004 20:00:58 -0400 (EDT) Received: from ludo.migus.org (ludo.migus.org [192.168.4.4]) by webservices.migus.org (IMP) with HTTP for ; Sat, 17 Apr 2004 20:00:58 -0400 Message-ID: <1082246458.4081c53aa98c4@webservices.migus.org> Date: Sat, 17 Apr 2004 20:00:58 -0400 From: "Adam C. Migus" To: Brooks Davis References: <1082233506.408192a2c476a@webservices.migus.org> <20040417235302.GC3534@Odin.AC.HMC.Edu> In-Reply-To: <20040417235302.GC3534@Odin.AC.HMC.Edu> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit User-Agent: Internet Messaging Program (IMP) 3.2.2 X-Originating-IP: 192.168.4.4 X-Virus-Scanned: by amavisd-new at migus.org cc: current@freebsd.org Subject: Re: VLAN support in rcNG [PATCH] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2004 00:01:09 -0000 Quoting Brooks Davis : > On Sat, Apr 17, 2004 at 04:25:06PM -0400, Adam C. Migus wrote: > > The following is a patch that adds support for vlan creation and > > destruction within rcNG. Using the patch it's possible, for > example, > > to create a vlan, `vlan0' with the following directives in > rc.conf: > > > > vlan_interfaces="vlan0" > > ifconfig_vlan0="DHCP" > > ifconfig_vlan0_vlan_dev="xl0" > > ifconfig_vlan0_vlan_tag="2" > > > > Is this patch of general interest? Should I submit a PR? > > If it wasn't for the patch I'm working on, I'd answer yes. > Howerver, > I've got a patch that I need to submit for review and then commit > that > will let you do this is a one shot with the clone code. It works by > doing a major overhaul of the device cloning support so you can > create > interfaces of the form . and get an vlan interface > with the appropriate parent and tag. Using your example that would > mean > you the follwing in your /etc/rc.conf: > > cloned_interfaces="xl0.2" > > -- Brooks > Brooks, Sounds great but when's it going to appear? Is it soon enough to negate the worth of this as an interim solution? Also, while on this topic I have a nit-pick. This convention, "." is pervasive but despite that, there's a lot of software that chokes on it. I've seen some shell-based firewall builders for example that don't like it. Does your overhaul patch support naming vlan interfaces "vlan" if the user desires it? If not would it be hard to do? I've patched my RH Linux based machines locally to do "vlan" for the aforementioned reason. -- Adam C. Migus -- http://people.migus.org/~adam/