From owner-freebsd-net@freebsd.org Mon Aug 31 10:07:24 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FEAD9C7308 for ; Mon, 31 Aug 2015 10:07:24 +0000 (UTC) (envelope-from btw@mail.ustc.edu.cn) Received: from ustc.edu.cn (email6.ustc.edu.cn [IPv6:2001:da8:d800::8]) by mx1.freebsd.org (Postfix) with ESMTP id BD41D796; Mon, 31 Aug 2015 10:07:22 +0000 (UTC) (envelope-from btw@mail.ustc.edu.cn) Received: from dell (unknown [182.112.31.34]) by newmailweb.ustc.edu.cn (Coremail) with SMTP id LkAmygD318BPJ+RVSjqnAA--.2822S2; Mon, 31 Aug 2015 18:07:17 +0800 (CST) Date: Mon, 31 Aug 2015 18:07:38 +0800 From: Tiwei Bie To: "Bjoern A. Zeeb" Cc: freebsd-net@freebsd.org, adrian@freebsd.org, hiren@freebsd.org Subject: Re: A bug in udp6_input() - should use proto instead of ip6->ip6_nxt Message-ID: <20150831100738.GA94313@dell> References: <1440993949-20698-1-git-send-email-btw@mail.ustc.edu.cn> <5FEE8C05-A25A-4A74-A8B0-4CA75A696D54@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5FEE8C05-A25A-4A74-A8B0-4CA75A696D54@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-CM-TRANSID: LkAmygD318BPJ+RVSjqnAA--.2822S2 X-Coremail-Antispam: 1UD129KBjvdXoWrKFWUJFyUCFy8JF47ZFW3Awb_yoWkCFXE9F y5Z34rC3yUAanFga13GF1FgrW7GrWqkFW5KF98XFs2yr93JrZruws3GasYvr1UJrnxWrnx uFn0vFya9rnF9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbF8YjsxI4VWDJwAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMc vjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCF04k20xvY0x0EwIxGrwCFx2IqxVCF s4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r 1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWU JVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r W3Jr0E3s1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8 JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8v_M3UUUUU== X-CM-SenderInfo: xewzqzxdloh3xvwfhvlgxou0/1tbiAQYSAVQhmDcQpwAEs9 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2015 10:07:24 -0000 On Mon, Aug 31, 2015 at 09:28:07AM +0000, Bjoern A. Zeeb wrote: > > > On 31 Aug 2015, at 04:05 , Tiwei Bie wrote: > > > > I found a bug in udp6_input(). The 'proto' parameter should be used to > > get the protocol number (UDP or UDPLITE), instead of ip6->ip6_nxt. > > > > Because ip6->ip6_nxt may be the protocol number of extension header, > > such as: > > > > If a UDP packet is an "atomic" fragment, frag6_input() will return > > directly, and ip6->ip6_nxt will be IPPROTO_FRAGMENT (if the first > > extension header is the fragment header) instead of IPPROTO_UDP or > > IPPROTO_UDPLITE: > > Hmm, that might be a bug elsewhere but atomic fragments are soon to go away again; wish people would listen in first place; but anyway. > > There are more of these bugs that came with the UDP-Lite code, such as 4mapped addresses are not handled correctly in the output path, etc. > > Can you open a bug for this and we can attach all the UDP-Lite fixes to it to properly document them and get them through review in a few days and committed? > Sure! ^_^ Here is the link: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202788 Best regards, Tiwei Bie