From owner-freebsd-hackers Tue Sep 4 8:50:22 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from alpha.dante.org.uk (alpha.dante.org.uk [193.63.211.19]) by hub.freebsd.org (Postfix) with ESMTP id 41D2237B408; Tue, 4 Sep 2001 08:50:12 -0700 (PDT) Received: from theta.dante.org.uk ([193.63.211.7] helo=dante.org.uk) by alpha.dante.org.uk with esmtp (Exim 3.12 #4) id 15eISe-0003fH-00; Tue, 04 Sep 2001 16:50:00 +0100 Message-ID: <3B94F834.C337F392@dante.org.uk> Date: Tue, 04 Sep 2001 16:50:13 +0100 From: Konstantin Chuguev Organization: Delivery of Advanced Network Technology to Europe Ltd. X-Mailer: Mozilla 4.76 [en] (X11; U; SunOS 5.6 sun4u) X-Accept-Language: ru, en MIME-Version: 1.0 To: Maxim Sobolev Cc: Poul-Henning Kamp , Brent Verner , current@FreeBSD.ORG, hackers@FreeBSD.ORG Subject: Re: Junior Kernel Hacker task: improve vnode->v_tag References: <200109041536.f84FaDG98107@vega.vega.com> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi Maxim, Perhaps you meant: diff -d -u -r1.154 vnode.h --- sys/vnode.h 2001/08/27 06:09:55 1.154 +++ sys/vnode.h 2001/09/04 15:21:25 @@ -175,6 +175,7 @@ /* open for business 0x100000 */ #define VONWORKLST 0x200000 /* On syncer work-list */ #define VMOUNT 0x400000 /* Mount in progress */ +#define VLOCKABLE 0x600000 /* vnode supports locking */ ...should be ^^^^^^^^ +#define VLOCKABLE 0x800000 /* vnode supports locking */ ? Regards, Konstantin. Maxim Sobolev wrote: > > In message <200109041343.f84DhO097646@vega.vega.com>, Maxim Sobolev writes: > > >> > > >> In message <20010904081337.A8968@rcfile.org>, Brent Verner writes: > > >> > > > >> >I've done a /cursory/ look over how this v_tag is used. I'm not sure > > >> >this is a simple/clean as you propose, since this is used in the > > >> >IS_LOCKING_VFS macro, as well as in union_subr.c... > > >> > > > Well, that is just too bad, because IS_LOCKING_VFS is wrong then. > > >> > > >> The places which inspect v_tag will have to be changed to use > > >> strcmp() then... > > > > > >I think that we can add a new vnode flag, say VCANLOCK, so that each > > >particular VFS can set it if it supports locking, which should allow > > >to remove pre-defined VFS list from the IS_LOCKING_VFS macro. I can > > >produce a patch if it sounds reasonably. > > > > Yeah, I think that makes a lot of sense. > > See attached. Please let me know if it is OK for you. > > -Maxim > > ---------------------------------------------------------------------- > Name: p > p Type: Plain Text (text/plain) > Encoding: 7bit > Description: ASCII C program text -- * * Konstantin Chuguev Francis House * * Application Engineer 112 Hills Road * Tel: +44 1223 302992 Cambridge CB2 1PQ D A N T E WWW: http://www.dante.net United Kingdom To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message