From owner-svn-src-all@FreeBSD.ORG Fri May 2 16:27:34 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6BAA597D for ; Fri, 2 May 2014 16:27:34 +0000 (UTC) Received: from nm12-vm0.bullet.mail.bf1.yahoo.com (nm12-vm0.bullet.mail.bf1.yahoo.com [98.139.213.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E61641E7F for ; Fri, 2 May 2014 16:27:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1399047672; bh=XkYQo96ntgS0KiDAhTsZoPmiJP1AjhXbnGIZKhProfA=; h=Received:Received:Received:X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=XxA9z9Y62P1RK29lQJHwe0ik/0puWryPKjHFn9/gvO6kELPixiKzsC9pkBuRAPYzIQiXHyNsdxih+IiSRjlsDW/MbRJgo3dXiUxemFKe/tfSfWr6054v3qhEGUCQ5XaibOL3adiylhHHeyIFFUqAl4wjoVOImbMi634mztob/WCiP9O9DWA45uMqbBwBcLyd9dwSM79P8blr+zlUqx8FiKJRZYfrHCEsfihJs1uZM0U8q+tWDRwYl1BAQ+0JWszmb5x3Z68HrY81b8FpOIvctdijFU69jgQrTWTOdOxig//f+3Q1DaL8y2vl86J94ABHKjC5O5T7qQOr986PNTfHJg== DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.com; b=HjUn7WI5RzKcoDiAbxamHKIHEu5XNObFQlNj9gcjxCSjGM6E/UvzwUx+zQl7DJPQQ+JZb68j5ZCkcGxhm7RuqWJKYxwetoigLnNZHt5xnvJ0FMWM4IV4pHshyBsy6bD85VXNsbtX6/s7rnCgR9CADVv5Me1haG1VID4iX7h+7WyBWj+V5anYtqVKFD8jj4S9Y9DaaACJU3ehB0TjAyygF9Er7OyJmmX231YkP6LDrNxoldUlBrf2Vx1ABxtXQL3IL50EXDEj1g792bU4i5OaAFtBck4UNJrEw6tfRQPNVTu24s5Now0wScNbxrGyZ1YOZqy7haL63ibL4g3rnqTOdQ==; Received: from [98.139.212.149] by nm12.bullet.mail.bf1.yahoo.com with NNFMP; 02 May 2014 16:21:12 -0000 Received: from [68.142.230.70] by tm6.bullet.mail.bf1.yahoo.com with NNFMP; 02 May 2014 16:21:12 -0000 Received: from [127.0.0.1] by smtp227.mail.bf1.yahoo.com with NNFMP; 02 May 2014 16:21:12 -0000 X-Yahoo-Newman-Id: 434026.64065.bm@smtp227.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: SozIFLgVM1ncTcxXz0lzLrudLhtCdkECLsJhKz8IjDqCy7o mSBoPc7iP5G6oYm_BlhXEEzzQP57ZLWUB96VhkDbri6Q8zRClhoaq69VOBXV u3m9CEGS2zxBhJ.MPukt.93p_ftHI.eHFQJBTfJ1Vb2QZ_nAQ8kjaeK7bPD7 ilValmTTTo82kBB3dWp.70rVLGhKJOF7K5XYRg7mOqgMDNa199IlZIs4z7hs A4OHHuETX.7yvMpbnBVM0nT9A82Z0uoF52VOs2Xp4QRFL.WKcnHo9X8knJWQ sUBFd5rTCLgKNF2HI8BiVoLrWUNtbPRc2BUq2isvAcUJniWN1ARStMpZZTSr 5Rr43GWZhRPU_GJ2d7DYLPTU5f0_mXBE8SkWoB696VV6iFFcKuFOMUbSziZH IgDwH1afxIZxCCGPNdq3OYzyv__oVeHnEhztIEc4gjY570TTST8h94rR5peA t9xzc4p2kbOP7ZzN9xhaBU8flaZ8k6rfScFKeQxMli74iQYqNoIa9f_DHvbH HM7OV7EOE4GbHmCwY4gviL3i_1wamRkshmQwy3qKgNGNI_XGO7u4SG0LeVy2 k9VCIETqfB.tkhjTAz9yFmaVA.gVGB7UezStJ1PAp3GvWMsF8.sK7Hst9Yba wmznF X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.102] (pfg@190.157.126.109 with plain [63.250.193.228]) by smtp227.mail.bf1.yahoo.com with SMTP; 02 May 2014 16:21:12 +0000 UTC Message-ID: <5363C5FF.7050602@freebsd.org> Date: Fri, 02 May 2014 11:21:19 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r265231 - head/contrib/gcc/config/i386 References: <201405021615.s42GFYH2030996@svn.freebsd.org> In-Reply-To: <201405021615.s42GFYH2030996@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 May 2014 16:27:34 -0000 On 05/02/14 11:15, Pedro F. Giffuni wrote: > Author: pfg > Date: Fri May 2 16:15:34 2014 > New Revision: 265231 > URL: http://svnweb.freebsd.org/changeset/base/265231 > > Log: > gcc: fix strict alignment. > > From the OpenBSD log: > > x86-64 ABI requires arrays greater than 16 bytes to be aligned to > 16byte boundary. However, GCC 16-byte aligns arrays of >=16 BITS, > not BYTES. > > This diff improves bug detectability for code which has local arrays > of [16 .. 127] bits: in those cases SSP will now detect even 1-byte > overflows. > > Obtained from: OpenBSD (CVS rev 1.4) > MFC after: 1 week I only plan to merge this to 10/stable since I am not really using 9/stable and I don't like running "risks" before a release. The fix looks interesting though so feel free to try to convince me if you have tested it :). Pedro. > Modified: > head/contrib/gcc/config/i386/i386.c > > Modified: head/contrib/gcc/config/i386/i386.c > ============================================================================== > --- head/contrib/gcc/config/i386/i386.c Fri May 2 15:52:50 2014 (r265230) > +++ head/contrib/gcc/config/i386/i386.c Fri May 2 16:15:34 2014 (r265231) > @@ -14408,7 +14408,7 @@ ix86_local_alignment (tree type, int ali > if (AGGREGATE_TYPE_P (type) > && TYPE_SIZE (type) > && TREE_CODE (TYPE_SIZE (type)) == INTEGER_CST > - && (TREE_INT_CST_LOW (TYPE_SIZE (type)) >= 16 > + && (TREE_INT_CST_LOW (TYPE_SIZE (type)) >= 128 > || TREE_INT_CST_HIGH (TYPE_SIZE (type))) && align < 128) > return 128; > } >