From owner-freebsd-current@FreeBSD.ORG Sat Apr 17 20:54:36 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A06016A4CE for ; Sat, 17 Apr 2004 20:54:36 -0700 (PDT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E3BD43D2D for ; Sat, 17 Apr 2004 20:54:36 -0700 (PDT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.10/8.12.3) with ESMTP id i3I3sZjU005524; Sat, 17 Apr 2004 20:54:35 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.10/8.12.3/Submit) id i3I3sZKj005523; Sat, 17 Apr 2004 20:54:35 -0700 Date: Sat, 17 Apr 2004 20:54:35 -0700 From: Brooks Davis To: "Adam C. Migus" Message-ID: <20040418035435.GF14645@Odin.AC.HMC.Edu> References: <1082233506.408192a2c476a@webservices.migus.org> <20040417235302.GC3534@Odin.AC.HMC.Edu> <20040417201913.P34536@sasami.jurai.net> <20040418005436.GC14645@Odin.AC.HMC.Edu> <1082258483.4081f43366454@webservices.migus.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="O98KdSgI27dgYlM5" Content-Disposition: inline In-Reply-To: <1082258483.4081f43366454@webservices.migus.org> User-Agent: Mutt/1.5.4i cc: current@freebsd.org Subject: Re: VLAN support in rcNG [PATCH] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2004 03:54:36 -0000 --O98KdSgI27dgYlM5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 17, 2004 at 11:21:23PM -0400, Adam C. Migus wrote: > Quoting Brooks Davis : >=20 > > On Sat, Apr 17, 2004 at 08:20:17PM -0400, Matthew N. Dodd wrote: > > > On Sat, 17 Apr 2004, Brooks Davis wrote: > > > > It works by doing a major overhaul of the device cloning support > > so you > > > > can create interfaces of the form . and get an > > vlan > > > > interface with the appropriate parent and tag. > > >=20 > > > Please make this behavior optional. > >=20 > > The entire patch has exactly one change which is visiable to the > > userland unless the user changes their behavior. That change is > > that > > when you do "ifconfig stf create" ifconfig does not output "stf0" > > and > > the interface created is named "sft" instead of "stf0". This is a > > result of a minor change that allows you to create "6to4" a more > > aptly named interface. This change is mostly an example of how to > > write > > new style interface cloners that's easier to understand then the > > vlan > > version which was the motivation for this overhaul. > >=20 > > The vlan change allows vlan interfaces to work exactly like they did > > before. It just adds some sugar so that the following sets of > > commands > > are equivalent: > >=20 > > ifconfig xl0.2 > >=20 > > vlanif=3D`ifconfig vlan create` > > ifconfig $vlanif name xl0.2 > > ifconfig xl0.2 vlandev xl0 vlantag 2 > >=20 > > -- Brooks > >=20 > > --=20 > > Any statement of the form "X is the one, true Y" is FALSE. > > PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 > >=20 >=20 > So it sounds like I say: >=20 > cloned_interfaces=3D"xl0.2" >=20 > and get myself the interface I want, on the right vlan but what happens > when I want to say: >=20 > ifconfig_xl0.2=3D"DHCP" >=20 > That `.' is going to cause some problems isn't it? Yah, that's a definite issue. I could add another seperator fairly easy, care to suggest one? > I asked earlier for reasons like this and compatability in general if > there would be a way to create vlan interfaces named "vlan2" for > example. > > The trouble with this naming convention is it doesn't imply it's > physical device in it's name but the name doesn't contain a `.' which > in things like sh(1) can cause problems. > > My patch may be a little more cumbersome, requiring explicit naming of > the device but it does eliminiate ambiquity and permit that naming > scheme with the ability to do DHCP and not trip over some other things > in rcNG. I don't have any strong objections to your patch. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --O98KdSgI27dgYlM5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFAgfv6XY6L6fI4GtQRApjCAJoDeE6WYKT6vSiR5eEfPaw/vWeiMgCg1Mqn qR7tt9j7D3L11BgFbQZtIt0= =0NY3 -----END PGP SIGNATURE----- --O98KdSgI27dgYlM5--