From owner-svn-ports-head@FreeBSD.ORG  Wed Aug 13 15:41:53 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4A71AE7B;
 Wed, 13 Aug 2014 15:41:53 +0000 (UTC)
Received: from prod2.absolight.net (mx3.absolight.net
 [IPv6:2a01:678:2:100::25])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 085F827C4;
 Wed, 13 Aug 2014 15:41:53 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
 by prod2.absolight.net (Postfix) with ESMTP id 4F65FBDC5C;
 Wed, 13 Aug 2014 17:41:51 +0200 (CEST)
Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client CN "gw.in.absolight.net",
 Issuer "CA Cert Signing Authority" (not verified))
 by prod2.absolight.net (Postfix) with ESMTPSA id 3B55BBDC56;
 Wed, 13 Aug 2014 17:41:51 +0200 (CEST)
Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239])
 by gw.in.absolight.net (Postfix) with ESMTP id ACAD0620C;
 Wed, 13 Aug 2014 17:41:50 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by ogg.in.absolight.net (Postfix) with ESMTP id 28ECB720613C;
 Wed, 13 Aug 2014 17:41:50 +0200 (CEST)
Date: Wed, 13 Aug 2014 17:41:49 +0200
From: Mathieu Arnold <mat@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>, Carlo Strub <cs@FreeBSD.org>
Subject: Re: svn commit: r364753 - in head/www/gatling: . files
Message-ID: <0F2D6AC291CD1849F46DBCD4@ogg.in.absolight.net>
In-Reply-To: <20140813152833.GA90841@FreeBSD.org>
References: <201408130315.s7D3FWYs042556@svn.freebsd.org>
 <1407942463.639247.546514528.132749.2@c-st.net>
 <20140813152833.GA90841@FreeBSD.org>
X-Mailer: Mulberry/4.0.8 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org, vanilla@FreeBSD.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Aug 2014 15:41:53 -0000



+--On 13 ao=C3=BBt 2014 15:28:33 +0000 Alexey Dokuchaev <danfe@FreeBSD.org>
wrote:
| On Wed, Aug 13, 2014 at 05:07:43PM +0200, Carlo Strub wrote:
|> 13/08/2014 05:16 - Vanilla I. Shu wrote:
|> > New Revision: 364753
|> > URL: http://svnweb.freebsd.org/changeset/ports/364753
|> > QAT: https://qat.redports.org/buildarchive/r364753/
|> >=20
|> > [...]
|> > -OPTIONS_DEFINE=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS
|> > -OPTIONS_DEFAULT=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS
|> > +OPTIONS_DEFINE=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS DOCS
|> > EXAMPLES DEBUG +OPTIONS_SUB=3D yes
|> > +OPTIONS_DEFAULT=3D BENCHMARKS SMB TLS ZLIB OPTIMIZED_CFLAGS DOCS
|> > EXAMPLES
|>=20
|> These large changes, especially the new options, merit a PORTREVISION
|> bump, no?
|=20
| No, why?  Default options already include DOCS and EXAMPLES; the above
| change in OPTIONS_DEFAULT is actually useless.

OPTIONS_DEFAULT, yes, but they were not present in OPTIONS_DEFINE, thus
were not there.  There should have been a PORTREVISION bump with this
change.

--=20
Mathieu Arnold