From owner-svn-src-all@FreeBSD.ORG  Mon Sep 14 20:13:31 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 647C2106566B;
	Mon, 14 Sep 2009 20:13:31 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Kris Kennaway <kris@FreeBSD.org>
Date: Mon, 14 Sep 2009 16:13:09 -0400
User-Agent: KMail/1.6.2
References: <200909112147.n8BLlind064388@svn.freebsd.org>
	<200909141238.23995.jkim@FreeBSD.org>
	<200909141608.53244.jkim@FreeBSD.org>
In-Reply-To: <200909141608.53244.jkim@FreeBSD.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200909141613.19957.jkim@FreeBSD.org>
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r197102 - head/sys/dev/amdtemp
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Sep 2009 20:13:31 -0000

On Monday 14 September 2009 04:08 pm, Jung-uk Kim wrote:
> Please try the attached patch.  I tried to implement all the quirks
> in Revision Guide carefully but I must admit that I haven't tried
> it on anything earlier than Revision F.

This patch has one typo:

+       /*
+        * Errata #154: Incorect Diode Offset
+        */
+       if (cpu_id == 0x20f32) {
+               do_cpuid(0x80000001, regs);
+               if ((regs[1] && 0xfff) == 0x2c)
                             ^^
                             &
+                       sc->sc_flags |= AMDTEMP_FLAG_DO_QUIRK;
+       }

Today is not my day. :-(

Sorry again,

Jung-uk Kim