From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Sep 22 12:23:59 2005 Return-Path: X-Original-To: freebsd-ports-bugs@FreeBSD.org Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 69F2B16A424 for ; Thu, 22 Sep 2005 12:23:59 +0000 (GMT) (envelope-from barner@gmx.de) Received: from mail.gmx.net (mail.gmx.de [213.165.64.20]) by mx1.FreeBSD.org (Postfix) with SMTP id BB1B843D45 for ; Thu, 22 Sep 2005 12:23:57 +0000 (GMT) (envelope-from barner@gmx.de) Received: (qmail invoked by alias); 22 Sep 2005 12:23:55 -0000 Received: from unknown (EHLO zi025.glhnet.mhn.de) [129.187.19.157] by mail.gmx.net (mp007) with SMTP; 22 Sep 2005 14:23:55 +0200 X-Authenticated: #147403 Received: by zi025.glhnet.mhn.de (Postfix, from userid 1000) id E1998C109; Thu, 22 Sep 2005 14:26:36 +0200 (CEST) Date: Thu, 22 Sep 2005 14:26:36 +0200 From: Simon Barner To: Thierry Thomas Message-ID: <20050922122636.GR25698@zi025.glhnet.mhn.de> References: <200509212039.j8LKdKpC071588@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rPgHZmYkQ+bUEpVC" Content-Disposition: inline In-Reply-To: <200509212039.j8LKdKpC071588@freefall.freebsd.org> User-Agent: Mutt/1.5.10i X-Y-GMX-Trusted: 0 Cc: freebsd-ports-bugs@FreeBSD.org, portmgr@FreeBSD.org Subject: Re: ports/85801: [NEW PORT] math/geogebra-i18n: A dynamic software that joins geometry, algebra and calculus X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2005 12:23:59 -0000 --rPgHZmYkQ+bUEpVC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Thierry Thomas wrote: > Synopsis: [NEW PORT] math/geogebra-i18n: A dynamic software that joins ge= ometry, algebra and calculus >=20 > State-Changed-From-To: open->feedback > State-Changed-By: thierry > State-Changed-When: Wed Sep 21 20:33:18 GMT 2005 > State-Changed-Why:=20 >=20 > This port is fine, but I would just make a minor suggestion: since > DISTNAME is not versioned, it would be easier to maintain if we include > PORTVERSION in DIST_SUBDIR. Could you please review the following patch? >=20 > --- geogebra-i18n.diff begins here --- > diff -urN math/geogebra-i18n.orig/Makefile math/geogebra-i18n/Makefile > --- math/geogebra-i18n.orig/Makefile Wed Sep 21 22:22:06 2005 > +++ math/geogebra-i18n/Makefile Wed Sep 21 22:25:23 2005 > @@ -12,7 +12,7 @@ > MASTER_SITES=3D http://www.geogebra.at/download/InstData/Java/ > DISTNAME=3D geogebra_setup > EXTRACT_SUFX=3D .jar > -DIST_SUBDIR=3D ${PORTNAME} > +DIST_SUBDIR=3D ${PORTNAME}-${PORTVERSION} What a nice idea! What about adding a suggestion to the Porters' Handbook? I've attached my suggestion (portmgr is Cc'ed), feel free to perform some grammar surgery or drop it in case you don't like it ;-) Best regards, Simon --rPgHZmYkQ+bUEpVC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDMqL8Ckn+/eutqCoRAk75AKDQViq4i7j9MpCQBcSNbihepmF4AQCfcgcv BqCubhLxYf1NBnaj07aM/WI= =P1m5 -----END PGP SIGNATURE----- --rPgHZmYkQ+bUEpVC--