From owner-svn-ports-head@freebsd.org Fri Jul 10 14:14:58 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9F993926; Fri, 10 Jul 2015 14:14:58 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 82BA927F; Fri, 10 Jul 2015 14:14:57 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.0.22] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 6E49543BC2; Fri, 10 Jul 2015 09:14:43 -0500 (CDT) Subject: Re: svn commit: r391626 - head/games/warzone2100 To: Dmitry Marakasov , marino@freebsd.org References: <201507090944.t699iqBR039850@repo.freebsd.org> <559E431B.6030708@marino.st> <20150709171246.GB46547@hades.panopticon> <559EAD6F.3050409@marino.st> <20150710135940.GB9933@hades.panopticon> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: John Marino X-Enigmail-Draft-Status: N1110 Reply-To: marino@freebsd.org Message-ID: <559FD34D.2080803@marino.st> Date: Fri, 10 Jul 2015 16:14:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150710135940.GB9933@hades.panopticon> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2015 14:14:58 -0000 On 7/10/2015 3:59 PM, Dmitry Marakasov wrote: > * John Marino (freebsd.contact@marino.st) wrote: > Like I've already said, the dependency is absolutely correct and does what > it should. It's a no-op though on all supported FreeBSD versions, > so I'm removing it. I've suggested (based on it's presence) that it should be pulling in textproc/flex, which is no longer does. IF this package is supposed to pull in the ports flex for a specific reason, then the change obviously prevents that. It's not clear to me why are you stating textproc/flex is a bad dependency. Somebody put it there intentionally. I would have tried to figure out the exact reason it was put there before declaring it is wrong. It must have been there for a reason. The dependency has always been a "no-op" so removing it based on that seems like weak logic to me. But -- I raised my concern. I'm not going to discuss it anymore. If warzone is busted because of these changes somebody will raise a PR. John