From owner-freebsd-current@FreeBSD.ORG  Mon Feb 21 15:47:42 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D9E4116A4CE; Mon, 21 Feb 2005 15:47:42 +0000 (GMT)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.10.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6E57943D45; Mon, 21 Feb 2005 15:47:41 +0000 (GMT)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (8.13.3/8.13.3) with ESMTP id j1LFlcVQ064764
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Mon, 21 Feb 2005 16:47:38 +0100 (CET)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.13.3/8.13.3/Submit) id j1LFlcKN064763;
	Mon, 21 Feb 2005 16:47:38 +0100 (CET)
Date: Mon, 21 Feb 2005 16:47:38 +0100
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: mlaier@freebsd.org
Message-ID: <20050221154738.GA64629@stud.fit.vutbr.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2i
X-Scanned-By: MIMEDefang 2.49 on 147.229.10.14
cc: current@freebsd.org
Subject: panic in altq
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Feb 2005 15:47:43 -0000

hi,

I was seeing panics on boot when pf was enabled.
this patch:

Index: altq_subr.c
===================================================================
RCS file: /home/ncvs/src/sys/contrib/altq/altq/altq_subr.c,v
retrieving revision 1.5
diff -u -r1.5 altq_subr.c
--- altq_subr.c	15 Jun 2004 23:59:37 -0000	1.5
+++ altq_subr.c	21 Feb 2005 15:44:21 -0000
@@ -93,7 +93,7 @@
 int (*altq_input)(struct mbuf *, int) = NULL;
 static struct mbuf *tbr_dequeue(struct ifaltq *, int);
 static int tbr_timer = 0;	/* token bucket regulator timer */
-static struct callout tbr_callout = CALLOUT_INITIALIZER;
+static struct callout tbr_callout;
 
 #ifdef ALTQ3_CLFIER_COMPAT
 static int 	extract_ports4(struct mbuf *, struct ip *, struct flowinfo_in *);
@@ -155,6 +155,7 @@
 	void *(*classify)(void *, struct mbuf *, int);
 {
 	IFQ_LOCK(ifq);
+	callout_init(&tbr_callout, 0);
 	if (!ALTQ_IS_READY(ifq)) {
 		IFQ_UNLOCK(ifq);
 		return ENXIO;


it completly solves (it used illegaly initialized callout, dunno hows possible
it worked before)

I hope for commiting this

roman