From owner-cvs-src@FreeBSD.ORG Mon Jan 14 21:58:28 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 946FA16A420; Mon, 14 Jan 2008 21:58:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id A326613C46B; Mon, 14 Jan 2008 21:58:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8q) with ESMTP id 228511827-1834499 for multiple; Mon, 14 Jan 2008 17:00:00 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id m0ELwC8a050809; Mon, 14 Jan 2008 16:58:16 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Kris Kennaway Date: Mon, 14 Jan 2008 15:54:52 -0500 User-Agent: KMail/1.9.7 References: <200801080800.m08806jI012963@repoman.freebsd.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org> In-Reply-To: <478BC55B.2060202@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200801141554.52748.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 14 Jan 2008 16:58:17 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/5483/Mon Jan 14 09:45:01 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Tim Kientzle , src-committers@freebsd.org, cvs-src@freebsd.org, obrien@freebsd.org, Tim Kientzle , cvs-all@freebsd.org, Dag-Erling Smorgrav Subject: Re: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2008 21:58:28 -0000 On Monday 14 January 2008 03:26:03 pm Kris Kennaway wrote: > David O'Brien wrote: > > >> If we have to special case ports to deal with variant zipfiles that cannot > >> be processed by /usr/bin/unzip then it gets messier because we have to > >> account for some ports being satisfied with USE_ZIP=yes meaning > >> /usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd > >> prefer not to have to add those workarounds. > > > > This seems quite easy... > > > > For those four-ish ports 's/USE_ZIP/USE_INFOZIP/' > > That's what I meant by "special case". I don't like adding special case > variables to bsd.*.mk for the benefit of a tiny number of ports; that > file is already cluttered enough. Also, if there are ports distfiles that unzip doesn't handle then there are likely other zip files in the wild that users may run into that it won't handle either. In that case, I think the ports distfiles are a good canary for seeing if unzip is suitable for widespread use. -- John Baldwin