From owner-freebsd-current@FreeBSD.ORG Wed Mar 3 08:28:40 2010 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3293B10656B5 for ; Wed, 3 Mar 2010 08:28:40 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 8C4738FC0C for ; Wed, 3 Mar 2010 08:28:39 +0000 (UTC) Received: by gya1 with SMTP id 1so687449gya.13 for ; Wed, 03 Mar 2010 00:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:organization:x-operation-sytem; bh=sLZtRLLpCcSjCMPyYhumM5GGQX91QKhCc24idhiHnTU=; b=xI+kOWO0gN0Xapdn8X+WWx2BPteEDNmR2H3ftVyPEhv/vcz7Oj7qDw7SahDDOD9GXP iqSw5vGh+fxwSLJSEM/SwxkFELgbRE80AlWoPd162A46+51QiyW1ap9pGRIdI585j20n 0hFFIpS8EPPXyMTadBHwnhgDWT04aPP4PXZiw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:organization:x-operation-sytem; b=tWyyokka+tA5ggL4TJWpAUvMNTBfuxE1Ki93DzmbGBuKHweGq/obdPUY3h0E8Goq6p OqDEYoEulOiKg/c4oSliTd0lCjdOTbP0YqDVGfiYyz1pnfqT945N1+V6fYUwkVt/7DZh y/aynhCnUljXSZXACBsBNEGEmVIGMXMi+KFfg= Received: by 10.100.83.3 with SMTP id g3mr1369365anb.3.1267604911901; Wed, 03 Mar 2010 00:28:31 -0800 (PST) Received: from weongyo ([174.35.1.224]) by mx.google.com with ESMTPS id 22sm4942595iwn.4.2010.03.03.00.28.30 (version=SSLv3 cipher=RC4-MD5); Wed, 03 Mar 2010 00:28:31 -0800 (PST) Received: by weongyo (sSMTP sendmail emulation); Wed, 3 Mar 2010 00:28:34 -0800 From: Weongyo Jeong Date: Wed, 3 Mar 2010 00:28:33 -0800 To: Alexandr Rybalko Message-ID: <20100303082833.GB22865@weongyo> Mail-Followup-To: Alexandr Rybalko , Alex RAY , current@freebsd.org References: <20091223035331.GA1293@weongyo> <4b31cb29.9413f30a.5f4a.ffff8382@mx.google.com> <20100226005115.GP14937@weongyo> <20100227011535.ed3f2486.ray@ddteam.net> <20100228095259.GB3536@weongyo> <20100301103240.3a4aac8a.ray@dlink.ua> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100301103240.3a4aac8a.ray@dlink.ua> User-Agent: Mutt/1.4.2.3i Organization: CDNetworks. X-Operation-Sytem: FreeBSD Cc: Alex RAY , current@freebsd.org Subject: Re: Call for Test and Review: bwn(4) - another Broadcom Wireless driver X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Weongyo Jeong List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2010 08:28:40 -0000 On Mon, Mar 01, 2010 at 10:32:40AM +0200, Alexandr Rybalko wrote: > On Sun, 28 Feb 2010 01:52:59 -0800 > Weongyo Jeong wrote: > > >> On Sat, Feb 27, 2010 at 01:15:35AM +0200, Alex RAY wrote: > >> > Hi Weongyo, > >> > > >> > Can new siba release operate in systems like in this SVG image? > >> > System example: CPU BCM5836 + Wi-Fi BCM4318 > >> > >> Recent changes of siba(4) by myself doesn't change code flow, layout and > >> doesn't include enhancements if you're an user of SENTRY5 mips CPU (like > >> BCM5836) > >> > >> All I did on recent changes were to put common routines or codes which > >> could be used for original siba(4). These codes are only used for > >> bwn(4) driver currently and don't be merged with original siba(4). That > >> means there are two separated codes in current siba(4) so merging two > >> into one is a TODO. > >> > >> I have no idea current siba(4) supports a system using on CPU BCM5836 + > >> Wi-Fi BCM4318 but in theory it should work without problems though I > >> didn't test. > >> > >> > And can we compile siba bus code without pci code? > >> > >> I think it looks that it could be possible to compile without pci code. > >> But makes sure that your device doesn't have PCI core. > > Can You test your driver without siba_switchcore, I see the device > have mapping for all cores on SSB? I see what you mean. siba_core.c which depends on PCI code would be compiled when it builds on SENTRY5. So it looks currently it needs a patch to compile siba bus code without PCI code. I'll try to make a patch. > > ssb0: mem 0xf4000000-0xf4003fff > Think thre is 4 cores. > When SSB on nexus, we don`t need core switching, maybe on PCI too. I think this is a difference between siba(4) and siba_bwn currently and it's one of TODOs we should solve to merge two codes. AFAIK approach to access each cores isn't same; it looks siba(4) creates devices for each cores so it'd not need to switch cores. But siba_bwn doesn't do it like siba(4) so it needs to switch cores because all are handled on one device. regards, Weongyo Jeong