From owner-freebsd-current  Mon Aug 20 22:53:28 2001
Delivered-To: freebsd-current@freebsd.org
Received: from beppo.feral.com (beppo.feral.com [192.67.166.79])
	by hub.freebsd.org (Postfix) with ESMTP
	id 66E2437B408; Mon, 20 Aug 2001 22:53:23 -0700 (PDT)
	(envelope-from mjacob@feral.com)
Received: from wonky.feral.com (wonky.feral.com [192.67.166.7])
	by beppo.feral.com (8.11.3/8.11.3) with ESMTP id f7L5rMI71828;
	Mon, 20 Aug 2001 22:53:22 -0700 (PDT)
	(envelope-from mjacob@feral.com)
Date: Mon, 20 Aug 2001 22:53:06 -0700 (PDT)
From: Matthew Jacob <mjacob@feral.com>
Reply-To: <mjacob@feral.com>
To: Bill Paul <wpaul@FreeBSD.ORG>
Cc: <hackers@FreeBSD.ORG>, <current@FreeBSD.ORG>
Subject: Re: Where to put new bus_dmamap_load_mbuf() code
In-Reply-To: <20010820223007.I39850-100000@wonky.feral.com>
Message-ID: <20010820225225.G39850-100000@wonky.feral.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


Correction.

This sample:
>
>         if (bus_dma_tag_create(pci->parent_dmat, PAGE_SIZE, lim,
>             BUS_SPACE_MAXADDR, BUS_SPACE_MAXADDR, NULL, NULL, len, 1,
>             BUS_SPACE_MAXSIZE_32BIT, 0, &pci->cntrol_dmat) != 0) {
>                 isp_prt(isp, ISP_LOGERR,
>                     "cannot create a dma tag for control spaces");
>                 free(isp->isp_xflist, M_DEVBUF);
>                 free(pci->dmaps, M_DEVBUF);
>                 return (1);
>         }
>

Should have been:

        if (bus_dma_tag_create(NULL, 1, 0, BUS_SPACE_MAXADDR_32BIT,
            BUS_SPACE_MAXADDR, NULL, NULL, lim + 1,
            255, lim, 0, &pcs->parent_dmat) != 0) {
                device_printf(dev, "could not create master dma tag\n");
                free(isp->isp_param, M_DEVBUF);
                free(pcs, M_DEVBUF);
                return (ENXIO);
        }



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message